Repository navigation
fix(or): join an or sharing no variable with earlier clauses as a cross product (#610, backport) - #613
Merged
Conversation
…ss product (#610) Backport of the v3 fix. apply_or_clauses' fast path replaced the incoming rows with the branch union when the two shared no user-visible variable, so after an earlier clause binding other variables every row was dropped. The special case is removed: the hash join with an empty key yields the cross product. or-join keeps refusing unbound join variables (INT-018). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HyLscCUuJ1GQpdAeX79EdR
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #612 (v3) to v2.0.x, for #610. Every bug fix goes to v2.0.x until v3.0.0.
[?x :edge ?z] (or [?p :edge :b] [?p :edge :c])returned no rows. The fast path inapply_or_clausesreplaced the incoming rows with the branch union when they shared no user-visible variable. It is removed, so the hash join with an empty key now gives the cross product.or-joinkeeps refusing unbound join variables (INT-018).Six new tests in
tests/disjunction_test.rs. Full suite: 1,264 passing, 9 ignored. CHANGELOG[Unreleased]and the test counts are updated.🤖 Generated with Claude Code
https://claude.ai/code/session_01HyLscCUuJ1GQpdAeX79EdR