Repository navigation
fuzz(datalog_eval): count partial bindings in the join guard (#597) - #600
Merged
Merged
Conversation
The guard skipped inputs whose patterns join to more than 50,000 rows but counted only the rows after the last pattern. A not-join body still runs on the executor pattern by pattern in text order, so the nightly's 120-pattern body built hundreds of thousands of partial bindings before its last pattern matched nothing, and timed out after 60 s. That is the known #575 limit (streaming engine, #546 for negation), not a new bug. The guard now counts the bindings after every pattern. On the v3 corpus (4,783 inputs) coverage drops from 9,719 to 9,712 edges. The input is added as a seed. Refs #597 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014v6aUco55yj3UScjL28mUP
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the
datalog_evalharness change from #599 (v3) tomain. Only the fuzz crate changes; the library is untouched.The guard skipped inputs whose patterns join to more than 50,000 rows, but it counted only the rows after the last pattern. A
not-joinbody runs on the executor pattern by pattern in text order. The nightly's 120-pattern body built hundreds of thousands of partial bindings before its last pattern matched nothing, and timed out after 60 s. That is the known #575 limit, not a new bug. The guard now counts the bindings after every pattern. Coverage on the v3 corpus goes from 9,719 to 9,712 edges over 4,783 inputs. The input is added as a seed and runs in about 145 ms onmain.Refs #597
🤖 Generated with Claude Code
https://claude.ai/code/session_014v6aUco55yj3UScjL28mUP