8000 Merge main into v3 (#481 bench fixture fsync) by adityamukho · Pull Request #482 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]
Skip to content

Merge main into v3 (#481 bench fixture fsync) #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityamukho merged 2 commits into from
Oct 8, 2026
Merged

Merge main into v3 (#481 bench fixture fsync) #482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c3cc77
ci(bench): fsync the copied file fixture before measuring (#426) (#481)
adityamukho Oct 8, 2026
0ee1432
Merge main into v3 (#481 bench fixture fsync, #426)
adityamukho Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions benches/helpers/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ pub fn populate_in_memory(n: usize) -> Arc<Minigraf> {
/// so building the file each time rebuilt 1m facts ~11 times per benchmark and
/// ran `insert_file` for hours (#393). The file for each `n` is built once and
/// copied to `path`; every caller still gets a fresh, identical file.
///
/// The copy is fsynced before returning. Otherwise its dirty pages are still
/// being written back while the benchmark runs, and every WAL fsync waits on
/// that writeback: the 1m copy made `insert_file/*/1m` 3-10x slower on about
/// half the nightly runs (#426).
pub fn populate_file(n: usize, path: &str) {
let mut fixtures = FILE_FIXTURES.lock().unwrap();
let fixtures = fixtures.get_or_insert_with(|| FileFixtures {
Expand All @@ -47,6 +52,7 @@ pub fn populate_file(n: usize, path: &str) {
template
});
std::fs::copy(template, path).unwrap();
std::fs::File::open(path).unwrap().sync_all().unwrap();
}

/// Delete the files built by [`populate_file`]. Statics are not dropped at
Expand Down
Loading
0