Repository navigation
Merge main into v3 (#470 BrowserDb regression tests) - #471
Merged
Merged
Conversation
…the IndexedDB flush (#470) checkpoint(), importGraph() and every write collected dirty pages with read_page_raw(id).ok() in a filter_map, so a page that failed to read was silently left out of the flush to IndexedDB while the call reported success. A shared take_dirty_pages helper (the same one v3 has since #469) now returns the read error. No current path leaves a dirty id without a page (ids enter the dirty set only after the page is stored), so this is defensive rather than a fix for observed loss. The browser unit tests did not compile on wasm32 (a duplicate page_cache_capacity from #341/#342, and dir_sync tests using tempfile); both are fixed so the two new regression tests run. Claude-Session: https://claude.ai/code/session_015GgLEs8YozJjYhwPEYgTUn Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts in src/browser/mod.rs, src/storage/persistent_facts.rs and docs/TEST_COVERAGE.md resolved to v3: v3 already has the same take_dirty_pages fix and wasm32 test-build repairs (#468, #469), so the duplicate helper and the duplicate CHANGELOG Fixed entry from main are dropped. Kept from main: the two regression tests and BrowserBufferBackend::mark_dirty_for_test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GgLEs8YozJjYhwPEYgTUn
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
main(596bb59, #470) intov3.v3 already has #470's fix (
take_dirty_pages) and the wasm32 test-build repairs from #468/#469. The conflicts insrc/browser/mod.rs,src/storage/persistent_facts.rsanddocs/TEST_COVERAGE.mdresolve to v3. I droppedmain's duplicate helper and its duplicate CHANGELOG### Fixedentry; v3's #469 entry already covers it.Net change to
v3:main's two regression tests (take_dirty_pages_returns_written_pages,unreadable_dirty_page_is_an_error_not_skipped), the test-onlyBrowserBufferBackend::mark_dirty_for_test, and the browser test count in TEST_COVERAGE, now 25.Checks: browser tests in headless Firefox pass 25/25,
cargo fmt --checkis clean, andclippy -D warningshas 0 findings on native, wasm32 browser and WASI. Native tests ran in the pre-push hook.Merge with a merge commit, not a squash.
🤖 Generated with Claude Code
https://claude.ai/code/session_015GgLEs8YozJjYhwPEYgTUn