8000 Benchmark regression: recursion (v3) · Issue #694 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]

Skip to content

Benchmark regression: recursion (v3) #694

Closed

Description

@github-actions

Bencher flagged these benchmarks in the nightly run (recursion, v3) on two runs in a row:

  • recursion/fanout/w10_d3

Branch: v3
Run: https://github.com/project-minigraf/minigraf/actions/runs/39829451304
Previous run: https://github.com/project-minigraf/minigraf/actions/runs/39651674021

Please review the Bencher dashboard to confirm the regression.

Activity

  1. added a commit that references this issue on Oct 23, 2026
  2. adityamukho commented on Oct 23, 2026

    @adityamukho
    Collaborator

    Fixed on v3 by #700 (4413d71). Cause: 97f27df (#548 PR 2) planned a recursive rule's delta run with the whole body's order after the delta, so after the magic-set rewrite the next clause shared no variable with the delta and joined as a product. Bench profile: fanout/w10_d3 4.94 s → 22.6 ms, chain/depth_100 699 → 41.5 ms, chain/depth_10 1.15 → 0.68 ms. Expect a few improvement-side Bencher swings on the next v3 runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performanceBenchmark performance regressions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0