FFFF Benchmark regression: open (main) · Issue #573 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]

Skip to content

Benchmark regression: open (main) #573

Closed as not planned
Closed as not planned

Description

@github-actions

Bencher flagged these benchmarks in the nightly run (open, main) on two runs in a row:

  • open/wal_replay/100k

Branch: main
Run: https://github.com/project-minigraf/minigraf/actions/runs/38373154795
Previous run: https://github.com/project-minigraf/minigraf/actions/runs/38225035471

Please review the Bencher dashboard to confirm the regression.

Activity

  1. adityamukho commented on Oct 13, 2026

    @adityamukho
    Collaborator

    Not a code regression. This is the same step as #561, re-alerting.

    open/wal_replay/100k on main (Bencher, ubuntu-latest):

    date commit latency
    10-09 339b31f 190 ms
    10-10 0da66eb 84 ms
    10-11 a861e55 (v2.0.5) 2665 ms
    10-12 72d847e 3031 ms
    10-13 d604cc4 2982 ms

    The step comes from #540 (backport of #476): before it, the usize::MAX close-time drop still saved the .graph, so this fixture replayed 0 WAL entries. It now replays all 100k, which is the work the benchmark is meant to measure. The latency has been flat at ~3 s since the step. Commits between the two alert runs (72d847e..d604cc4) are CI, a unit test and a fuzz corpus only; 1k and 10k are unchanged.

    #568 (merged today) limits the comparison to the last 30 runs, so a lasting step alerts for a few more runs and then becomes the baseline. Further re-fires of this benchmark at ~3 s can be closed the same way.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performanceBenchmark performance regressions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0