8000 ci: add MSRV check, public-API semver check, and dependency policy check · Issue #395 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]

Skip to content

ci: add MSRV check, public-API semver check, and dependency policy check #395

Closed

Description

@adityamukho

Problem

  • rust-version = "1.89" is declared in Cargo.toml, but no CI job builds with 1.89. CI uses stable only, so a newer-toolchain feature can break the MSRV without anyone noticing.
  • No check stops an accidental breaking change to the public API. v2.0.0 happened partly because of breaks found by hand (OpenOptions struct literals).
  • cargo-audit and OSV-Scanner run, but nothing enforces license or source rules for dependencies.

Ask

  • Add an MSRV job: cargo +1.89 check --all-features and cargo +1.89 test --lib.
  • Add cargo-semver-checks against the latest release tag on PRs to main. Allow the check to be overridden only on major-version branches such as v3.
  • Add cargo-deny with a license allow-list (MIT/Apache-2.0 compatible), a ban on duplicate major versions where practical, and a check that every crate comes from crates.io.

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency filestabilityStability/panic issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0