8000 bench: cover python FFI costs for core #776 P16 by adityamukho · Pull Request #17 · project-minigraf/minigraf-python · GitHub
[go: up one dir, main page]

Skip to content

bench: cover python FFI costs for core #776 P16 - #17

Merged
adityamukho merged 2 commits into
v3from
bench/776-p16-bindings
Nov 3, 2026
Merged

adityamukho merged 2 commits into
v3from
bench/776-p16-bindings

Conversation

@adityamukho
Copy link
Copy Markdown
Contributor

Adds #776 P16 G15 representatives through the actual python runtime, with no core behavior or production dependency changes.

New IDs: binding/python/{prepared_execute/1k,cursor_batch_1/1k,cursor_batch_256/1k,set_roundtrip/2,predicate/1k,aggregate/1k}.

Setup/preparation/registration happen outside measurement; the fixed 1k-fact fixture checks point/set results and drain/callback counts and sums. --test runs each ID exactly once without timers or metrics files. Host decoding and cursor close are included in the round trip.

Route: core #832 and identical main companion #833, bench / binding_python matrix job, entire fixed shortlist. Dedicated binding-python-ubuntu24-v1 Bencher testbed; 5–15 job-minutes plus build/runtime setup provisionally reserved, unverified. Land binding code before those core routes. Phase B can select binding-ref=bench/776-p16-bindings before merging.

Validation: local release build and untimed --test passed, also with a temporary Cargo patch to the P16 core checkout. No timed local run, remote benchmark-machine access, or Actions benchmark dispatch. Normal CI and the read-only Codex review are tracked in follow-up comments. Manual Java/Android/Swift/WASI and other follow-up dispositions live in the core guide. No CHANGELOG change, matching the core benchmark PR precedent.

Refs #776; source issue: project-minigraf/minigraf#776.

🤖 Generated with Codex, orchestrated by Claude Code

adityamukho and others added 2 commits November 3, 2026 15:28
Exercise prepared execute, cursor batch sizes, set round trips and host callbacks with a deterministic fixture and untimed test mode.

Co-Authored-By: Codex <noreply@openai.com>
…s #776)

Apply verified read-only review findings; all cases rechecked once with untimed test mode.

Co-Authored-By: Codex <noreply@openai.com>
@adityamukho
Copy link
Copy Markdown
Contributor Author

Phase-A untimed evidence after review fixes:

target/bench-venv/bin/python bench/nightly.py --test
ok: binding/python/prepared_execute/1k
ok: binding/python/cursor_batch_1/1k
ok: binding/python/cursor_batch_256/1k
ok: binding/python/set_roundtrip/2
ok: binding/python/predicate/1k
ok: binding/python/aggregate/1k

Each ID ran once in this check. The same cases also passed against the P16 core source using a temporary Cargo patch, without changing the release dependency pin. No local/remote timing, SSH or benchmark workflow dispatch was performed.

Read-only review: codex exec -m gpt-6-astra -s read-only ... < /dev/null. Both verified findings fixed: checksum reductions now run after timing, and the README build recipe is valid shell. No findings were rejected. All cases were rechecked after the fixes.

Route: core #832/#833 bench / binding_python, whole fixed shortlist, dedicated binding-python-ubuntu24-v1 testbed. Timing/upload history is deliberately deferred to serial phase B. Normal CI: green on the latest head (13 passing checks; gh pr checks --watch exited 0).

@adityamukho
adityamukho merged commit 16f54fe into v3 Nov 3, 2026
13 checks passed
@adityamukho
adityamukho deleted the bench/776-p16-bindings branch November 3, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0