Repository navigation
feat: prepared queries with MinigrafBindable Swift values (minigraf#181) - #13
Merged
Merged
Conversation
…ror.Api (minigraf#181) Shim from minigraf-binding-template#7 and core pin 5f2ba46e (minigraf#738). MinigrafKit+Prepared.swift: pq.execute(["slot": v]) / pq.query(...) over MinigrafBindable (Bool, Int*, Double, Float, String, UUID, MiniGrafValue, MiniGrafBindValue; nil is Null). MiniGrafError.message covers .Api. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 3 (swift) of project-minigraf/minigraf#181 (spec §4.2, §5, §7.1; plan steps 11–14).
src/lib.rscopied from feat: prepared queries and MiniGrafError::Api (minigraf#181) minigraf-binding-template#7; core pin andCargo.lockat5f2ba46e(minigraf#738).Sources/MinigrafKit/MinigrafKit+Prepared.swift: aMinigrafBindableprotocol adopted byBool,Int,Int32,Int64,Double,Float,String,UUID(an entity),MiniGrafValueandMiniGrafBindValue, pluspq.execute(["slot": v])/pq.query(...)taking[String: (any MinigrafBindable)?](nilisNull).MiniGrafError.Api;MiniGrafError.messagecovers it.Tests/swift/main.swift(repeated execution checked per row, every plain type,UUIDin entity and value slots, typed values, the cursor,Apiwith API-017/022/023/024), andtestPreparedQueryin the consumer contract. README: a Prepared queries section.The Rust shim's 33 tests pass on the bench machine. There's no Swift toolchain locally, so this PR's macOS CI jobs are the first compile of the Swift code.
Merge after minigraf-binding-template#7.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x