Repository navigation
feat: prepared queries with plain JS bind values (minigraf#181) - #18
Merged
Merged
Conversation
Core pin 5f2ba46e (minigraf#738). MiniGrafDb.prepare -> PreparedQuery
with execute(bindings) / query(bindings): booleans, numbers (integer
when Number.isInteger), bigints, strings and null bind as values;
FactValue and {type: entity|txCount|timestamp|anyValidTime} forms for
the rest; anything else is a TypeError. close() empties every prepared
query, so the path reopens; a prepared query used after close() throws
API-018.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x
…flake) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4 (node) of project-minigraf/minigraf#181 (spec §4.2, §5, §6, §7.2; plan step 15).
MiniGrafDb.prepare(text)→PreparedQuerywithexecute(bindings)(JSON) andquery(bindings)(Cursor), exported fromminigraf.jsandindex.js.index.d.tsregenerated bynapi build.null, bigints and numbers (an integer whenNumber.isIntegeraccepts it, else a float; outside i64 →API-017) bind as values. The typed forms areFactValue({ type: 'float', value: 2 },'keyword','ref', ...),{ type: 'entity' },{ type: 'txCount' | 'timestamp' }(number or bigint) and{ type: 'anyValidTime' }. A value that isn't a bind value throws a realTypeError(thrown on the env and returned asPendingException); a throwing getter propagates its own error.MiniGrafDbkeeps a weak list of its prepared queries.close()empties them before dropping the database, so the documented reopen works.prepareholds the db lock while it adds to the list, so aclose()can't miss one. A prepared query used afterclose()throws[API-018] database is closed.npm testalso runtest/prepared.test.mjs. Consumer contract: a prepared query run with plain and typed values. README: a Prepared queries section.Tests (local, Node 24): 21/21, 7 new: repeated runs checked per row, every plain and typed form, the
2vs{type:'float'}rule, the cursor,TypeErrors, API-017/018/022/023/024/005, reopen afterclose()with a prepared query alive. The contract passes. Clippy clean. Codex: one finding (getter errors were swallowed), fixed.Found while checking spec §6: an open cursor or fact log already blocks reopening after
close(). Filed as #17, not fixed here.🤖 Generated with Claude Code
https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x