Repository navigation
feat: open options, query cursors, fact log and log writer (v3) - #9
Merged
Merged
Conversation
Exposes the v3 core's ETL surface with the shim shared by the UniFFI bindings (minigraf-python#6), following minigraf's docs/superpowers/specs/2026-10-07-binding-etl-surface-design.md: open_with_options (project-minigraf/minigraf#465), query cursors (#462), and the fact log and log writer (#467). Java idiom on top: Minigraf.options() and Minigraf.filter() builders, openWithOptions, createLogWriter, batches()/records() iterables, and errorMessage(e). UniFFI objects are AutoCloseable, so the shim's own close methods are renamed to release() and abandon() in uniffi.toml. Depends on the unreleased v3 core by git revision; switches to the crates.io release at v3.0.0. CI runs on pushes to v3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GgLEs8YozJjYhwPEYgTUn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JVM part of project-minigraf/minigraf#462, #465 and #467. It uses the UniFFI shim shared with minigraf-python#6 and the shape in minigraf's
docs/superpowers/specs/2026-10-07-binding-etl-surface-design.md(minigraf PR #468).What's new
MiniGrafDb.openWithOptions(path, OpenOptions),query()→MiniGrafCursor,factLog(FactFilter)→MiniGrafFactLog,currentTxCount(), andMiniGrafLogWriter(create,append,appendBatch,advanceTxCount,txCount,finish,abandon,isOpen).Minigraf.options()/Minigraf.filter()builders,openWithOptions,createLogWriter,batches(cursor, n)/records(log, n)iterables,errorMessage(e)andVALID_TIME_FOREVER. Kotlin getscursor.batches()andlog.records()extensions.AutoCloseablein Kotlin, so try-with-resources frees them, and closing a writer that never finished abandons its build. The shim's ownclosemethods clash with that, souniffi.tomlrenames them torelease()(cursor, fact log) andabandon()(writer). ThegenerateKotlinBindingstask now listsuniffi.tomlas an input, so a rename change regenerates the bindings.Long/Int. Kotlin'sULong/UIntare name-mangled and cannot be called from Java. The shared shim was changed for this in minigraf-python#6.Branching
Targets the new
v3branch, a copy ofmain.minigrafis a git dependency on the corev3commit from PR #468. CI now also runs on pushes tov3; PRs already ran for every base.Testing
cargo test: 25 passed../gradlew test: 19 passed. The new tests areEtlTest.kt(6) and a Java interop test that uses builders, try-with-resources, the iterables and the record constructor. Together they cover batches of 1/7/1000 equal toexecute(), a cursor fixed at open, API-012, read-only queries/API-014/STG-042/two readers/STG-02x, filters and API-017, a round trip with identical records andcurrentTxCount, a hole from a skipped transaction, API-015 with batch index, API-018, STG-043, and abandon/close leaving no file.🤖 Generated with Claude Code
https://claude.ai/code/session_015GgLEs8YozJjYhwPEYgTUn