Repository navigation
fix: let wal_checkpoint_threshold reach the never-checkpoint sentinel - #10
Merged
Merged
Conversation
Same shim change as minigraf-python#7: i64::MAX now maps to core's usize::MAX sentinel, so the checkpoint on close can be suppressed (project-minigraf/minigraf#322). Since counts became i64 the largest value only delayed automatic checkpoints, and the doc comment was wrong. Refs project-minigraf/minigraf#322 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GgLEs8YozJjYhwPEYgTUn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sa 8000 me shim change as minigraf-python#7. Core skips the close-time checkpoint only for
wal_checkpoint_threshold == usize::MAX. With counts asi64, the largest value (2^63−1) only delayed automatic checkpoints, so project-minigraf/minigraf#322's escape hatch was unreachable.i64::MAXnow maps tousize::MAX, and the doc comment is fixed.Java/Kotlin:
Minigraf.WAL_CHECKPOINT_NEVER, plus a test that the WAL survivesclose()../gradlew test: 20 passed.cargo test: 26 passed, including a test that a dropped handle keeps its WAL withi64::MAXbut still checkpoints withi64::MAX - 1.Refs project-minigraf/minigraf#322
🤖 Generated with Claude Code
https://claude.ai/code/session_015GgLEs8YozJjYhwPEYgTUn