8000 settings-system: remove unneeded span elements by XhmikosR · Pull Request #3468 · pi-hole/web · GitHub
[go: up one dir, main page]
Skip to content

settings-system: remove unneeded span elements - #3468

Merged
yubiuser merged 2 commits into
pi-hole:developmentfrom
XhmikosR:xmr/rm-set-adv-span
May 18, 2025
Merged

settings-system: remove unneeded span elements#3468
yubiuser merged 2 commits into
pi-hole:developmentfrom
XhmikosR:xmr/rm-set-adv-span

Conversation

@XhmikosR
@XhmikosR XhmikosR commented May 18, 2025 •
edited
Loading
Copy link
Copy Markdown
Contributor

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

XhmikosR added 2 commits May 18, 2025 22:37
settings-system: remove unneeded span elements
5b1d4f6 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
settings-system: drop unused lookatme-text attribute
851cdf4 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@yubiuser
yubiuser merged commit 0d883e3 into pi-hole:development May 18, 2025
@PromoFaux PromoFaux mentioned this pull request May 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XhmikosR @yubiuser
0