Fix memory leak of doc blocks of static properties #12238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When declaring the same static property with a doc block in a class and in a trait, the doc block of the property in the class is leaked. This fixes php#12207.
iluuu1994
reviewed
Sep 18, 2023
| * class comment | ||
| */ | ||
| static $property; | ||
| } |
There was a problem hiding this comment.
Please close the PHP block. This makes tests directly executable.
staabm
reviewed
Sep 18, 2023
Zend/zend_API.c
Outdated
| @@ -4350,6 +4353,9 @@ ZEND_API zend_property_info *zend_declare_typed_property(zend_class_entry *ce, z | |||
| (property_info_ptr->flags & ZEND_ACC_STATIC) == 0) { | |||
| property_info->offset = property_info_ptr->offset; | |||
| zval_ptr_dtor(&ce->default_properties_table[OBJ_PROP_TO_NUM(property_info->offset)]); | |||
| if (property_info_ptr->doc_comment) { | |||
There was a problem hiding this comment.
Sorry 🙈 Fixed: bf6cb25
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When declaring the same static property with a doc block in a class and in a trait, the doc block of the property in the class is leaked.
This fixes #12207.