[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test curl_basic_024 fails with curl 8.8.0 #14307

Closed
rbgarga opened this issue May 23, 2024 · 3 comments
Closed

Test curl_basic_024 fails with curl 8.8.0 #14307

rbgarga opened this issue May 23, 2024 · 3 comments
Labels
Bug Category: Tests Extension: curl Status: Verified

Comments

@rbgarga
Copy link
rbgarga commented May 23, 2024

Description

After building PHP 8.3.7 on Chimera Linux and run test suite there is one test failing:

ext/curl/tests/curl_basic_024.phpt

Here is the log:

  ---- EXPECTED OUTPUT
  bool(true)
  bool(true)
  string(4) "HTTP"
  ---- ACTUAL OUTPUT
  bool(true)
  bool(true)
  string(4) "http"
  ---- FAILED

This test was passing without problems with older curl versions.

PHP Version

PHP 8.3.7

Operating System

Chimera linux
@nielsdos
Copy link
Member

I can reproduce this. The data comes straight out of curl so I think we should simply update the test to tolerate both forms.

nielsdos added a commit to nielsdos/php-src that referenced this issue May 23, 2024
@nielsdos
Fix phpGH-14307: Test curl_basic_024 fails with curl 8.8.0
ab2c698
@nielsdos nielsdos linked a pull request May 23, 2024 that will close this issue
Fix GH-14307: Test curl_basic_024 fails with curl 8.8.0 #14312
Closed
@lucasnetau
Copy link
Contributor

There was a change done to Curl two weeks ago to lower case scheme

lib: make protocol handlers store scheme name lowercase curl/curl@c294f9c

CURLINFO_SCHEME documentation now notes

The returned scheme might be upper or lowercase. Do comparisons case insensitively.

@nielsdos
Copy link
Member

Thanks for the link @lucasnetau !
I'll include it in the commit's description.

nielsdos added a commit that referenced this issue May 24, 2024
@nielsdos
Merge branch 'PHP-8.2' into PHP-8.3
ae26dc1 
* PHP-8.2:
  Fix GH-14307: Test curl_basic_024 fails with curl 8.8.0
nielsdos added a commit that referenced this issue May 24, 2024
@nielsdos
Merge branch 'PHP-8.3'
9ad1779 
* PHP-8.3:
  Fix GH-14307: Test curl_basic_024 fails with curl 8.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Category: Tests Extension: curl Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GH-14307: Test curl_basic_024 fails with curl 8.8.0 nielsdos/php-src
3 participants
@rbgarga @nielsdos @lucasnetau