-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP fails to build if openssl was built with --no-ec #9064
Comments
Lex-2008
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Jul 20, 2022
Indeed, looks like this occurrence has been overlooked. |
cmb69
added
Extension: openssl
Status: Verified
and removed
Status: Needs Triage
labels
Jul 20, 2022
Lex-2008
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Jul 21, 2022
also remove no-ssl from solaris Note that: PHP doesn't work without these: no-md2 no-md4 no-md5 no-rmd160 according to php/php-src#8430 And also no-ec: php/php-src#9064
vpodzime
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Aug 2, 2022
also remove no-asm from solaris Note that: PHP doesn't work without these: no-md2 no-md4 no-md5 no-rmd160 according to php/php-src#8430 And also no-ec: php/php-src#9064
vpodzime
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Aug 2, 2022
also remove no-asm from solaris Note that: PHP doesn't work without these: no-md2 no-md4 no-md5 no-rmd160 according to php/php-src#8430 And also no-ec: php/php-src#9064
Lex-2008
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Aug 19, 2022
also remove no-asm from solaris Note that: PHP doesn't work without these: no-md2 no-md4 no-md5 no-rmd160 according to php/php-src#8430 And also no-ec: php/php-src#9064
Lex-2008
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Sep 12, 2022
also remove no-asm from solaris Note that: PHP doesn't work without these: no-md2 no-md4 no-md5 no-rmd160 according to php/php-src#8430 And also no-ec: php/php-src#9064
Lex-2008
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Sep 12, 2022
Also, store all openssl config flags in dedicated files, to be stored centrally and used on all platforms. Also run configdata.pm --dump to show enabled features Also note that this removes no-asm from solaris Ticket: ENT-8933 Note that PHP doesn't work without: md2 md4 md5 rmd160, according to php/php-src#8430 And also without ec, according to php/php-src#9064
Lex-2008
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Sep 21, 2022
Also, store all openssl config flags in dedicated files, to be stored centrally and used on all platforms. Also run configdata.pm --dump to show enabled features Also note that this removes no-asm from solaris Ticket: ENT-8933 Note that PHP doesn't work without: md2 md4 md5 rmd160, according to php/php-src#8430 And also without ec, according to php/php-src#9064
Lex-2008
pushed a commit
to Lex-2008/buildscripts
that referenced
this issue
Sep 22, 2022
Also, store all openssl config flags in dedicated files, to be stored centrally and used on all platforms. Also run configdata.pm --dump to show enabled features Also note that this removes no-asm from solaris Ticket: ENT-8933 Note that PHP doesn't work without: md2 md4 md5 rmd160, according to php/php-src#8430 And also without ec, according to php/php-src#9064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Looking at openssl.c:
HAVE_EVP_PKEY_EC
is defined only ifOPENSSL_NO_EC
is defined:https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L89
OPENSSL_KEYTYPE_EC
is defined only ifHAVE_EVP_PKEY_EC
is defined:https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L107
but then on line 4899 it is used without proper
#ifdef
's:https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L4898
Worth noting that further down it's properly
#ifdef
'd out:https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L5003
Probably it should be
#ifdef
'd on line 4899, too?PHP Version
8.1.8
Operating System
No response
The text was updated successfully, but these errors were encountered: