8000 Add ability to validate .traker.yml by veelenga · Pull Request #6 · pavloo/traker · GitHub
[go: up one dir, main page]

Skip to content

Add ability to validate .traker.yml - #6

Merged
veelenga merged 1 commit into
pavloo:masterfrom
veelenga:feat/config-validation
Oct 8, 2020
Merged

veelenga merged 1 commit into
pavloo:masterfrom
veelenga:feat/config-validation

Conversation

@veelenga
@veelenga veelenga commented Oct 7, 2020 •
Copy link
Copy Markdown
Collaborator

This PR adds a possibility to maintain/validate .traker.yml by the end app using specs.

  • created Config entity which represents the config itself and implements the #validate! method.
  • added a spec generator, which creates an rspec file to validate the .traker.yml
  • added specs and docs

@pavloo pavloo left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pavloo pavloo mentioned this pull request Oct 7, 2020
@pavloo
pavloo commented Oct 7, 2020
Copy link
Copy Markdown
Owner

@veelenga feel free to merge when it's ready to go

@veelenga
veelenga merged commit 32db290 into pavloo:master Oct 8, 2020
@veelenga
veelenga deleted the feat/config-validation branch October 8, 2020 07:09
@veelenga
veelenga commented Oct 8, 2020
Copy link
Copy Markdown
Collaborator Author

@pavloo thanks, man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0