Repository navigation
fix(settings): drop the import #7719 left unused (Ruff F401) - #2
Closed
roshangupta00750 wants to merge 1 commit into
Closed
roshangupta00750 wants to merge 1 commit into
roshangupta00750 wants to merge 1 commit into
Conversation
Osmantic#7719 replaced main.py's only use of _read_env_map_from_path, so Ruff's F401 check fails the Lint Python job.
4 of 7 tasks
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
Closing, since Osmantic#7719 already drops the unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Osmantic#7719.
That PR replaced
main.py's only use of_read_env_map_from_path, so theLint Python with Ruffjob fails with:This removes it from the
from settings import (...)list. Nothing else inmain.pyor the tests refers to it.With CI's exact commands (
ruff 0.15.12,--select E,F,W --ignore E501,E701,E731,E741,E402, plus the py39E9check): the PR head reports the F401 error; with this commit both report "All checks passed!".AI assistance was used for analysis and drafting the fix. I reproduced the failure and verified the results above myself.