Repository navigation
Dashboard generator should skip Plain Ruby Objects, not backed by ActiveRecord, without raising an exception and halting mid process. - #1
Open
rietta wants to merge 3 commits into
Conversation
options for the model. This appears to have been triggered on a project that had a number of domain specific, non-ActiveRecord classes within the models path.
message indicated that including this file was neccesary.
ActiveRecord was loaded. This new test asserts that such a PORO does not raise an error and the rescue in the generator returns a default value when one of these exceptions is raised. All existing tests still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
rails generate administrate:installon a project would fail part way through if the project contained non-ActiveRecord Ruby objects in the models folder. I've added a test to exercise this bug and two rescues in the dashboard_generator to return an empty value when the case is encountered. The goal is that the non-database object should be skipped. All tests are passing.