-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python path resolution on linux #1196
Fix python path resolution on linux #1196
Conversation
Would love to see this merged & released! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test please and merge conflict.
I added some tests. I could not come up with a good way of reproducing this exact issue in a test suite without requiring multiple python versions to be installed on the runner, which I think would not be great for local execution. Let me know if you have other ideas @gaborbernat. BTW we could set |
@gaborbernat thanks for merging ! In this message, @Gitznik mentionned that they were expecting to change one line, but I think you merged before they had an opportunity to do that (well, the tool was broken, so it's a good decision whatsoever). Do we want to make a follow-up PR with the suggested simplification, or drop it altogether? |
docs/changelog.md
Summary of changes
Only use the logic introduced in #1168 to fix a path resolution issue on windows when pipx is running on a Windows machine.
This fixes #1195
Test plan
When no venv for python3.9 exists, but python is on the PATH (in my case via pyenv):
Before this change leads to the error described in #1195 , and works after this change.
Tested by running