Use map_overlap for rolling reductions with Dask
#9770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI is green, anything I should check here? cc @dcherian FYI |
dcherian
reviewed
Nov 12, 2024
dcherian
reviewed
Nov 12, 2024
|
I guess this means I can simplify #9720 since we don't need it for the built-in reductions? |
unfortunately no, more than one windowing dim takes the construct path :( |
|
The doc build thing is unrelated |
|
Looks good! |
map_overlap for rolling reducers with Daskmap_overlap for rolling reductions with Dask
|
Failures seem unrelated |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Nov 16, 2024
* main: fix cf decoding of grid_mapping (pydata#9765) Allow wrapping `np.ndarray` subclasses (pydata#9760) Optimize polyfit (pydata#9766) Use `map_overlap` for rolling reductions with Dask (pydata#9770) fix html repr indexes section (pydata#9768)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rstThis enables Dasks map_overlap for rolling reductions, the previous issues with memory consumption are now handled in map_overlap as far as I can tell