Repository navigation
Conversation
Bump the project version from 0.3.5-alpha to 0.4.0-alpha, switch the libCZI fetch source to ptahmose/libCZI on origin/jbl/XT, and disable building czicmd.
Update build.yml to use actions/checkout@v5, matlab-actions/setup-matlab@v3, and actions/upload-artifact@v5 in build and release jobs without changing workflow logic.
Upgrade `matlab-actions/run-command` to v3 and `actions/upload-artifact` to v7 for MATLAB and Octave MEX artifact uploads. No build logic changed.
Support optional semicolon-separated Open-reader key=value options in `MEXlibCZI('Open', ...)` and `octavelibczi`, pass them through `CziReader::Open` to libCZI, add validation and MATLAB tests, update docs, bump version to `0.5.0-alpha`, and reformat `CziReader.cpp`.
Use `filename.c_str()` in `MexFunction_Open_Execute` when logging the file name with a `%s` formatter, ensuring a C-style string is passed before calling `reader->Open(filename, open_options)`.
Update the test to validate `dimensionSwapWorkaround=XtSubblocks` when opening CZI files.
Validate bounding-box correction with a new CZI fixture while preserving subblock count.
Add an Xztest.czi fixture and MATLAB coverage for opening it with and without the dimension-swap workaround. Leave expected metadata assertions as TODOs.
Updated example usage for MEXlibCZI and corrected unit notation.
use mainline-libCZI
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Dependency compatibility and runtime behavior remain unverified, and the XZ regression test lacks behavioral assertions.
1 open issue
What changed in this PR
Adds optional libCZI reader options to support the line-scan workaround described in #16.
Changes:
- Pass optional
Openoptions through to libCZI and document usage. - Add MATLAB tests for XT and XZ dimension workarounds.
- Pin libCZI, bump the project version, and update build actions.
| File | Description |
|---|---|
| tests/MATLAB/TestMEXlib_OpenOptions.m | Adds dimension-workaround tests. |
| modules/libCZI.cmake | Pins libCZI to a specific commit. |
| lib/src/implementation/CziReader.h | Declares optional open options. |
| lib/src/implementation/CziReader.cpp | Parses and forwards options; reformats existing code. |
| lib/src/functions/func_open.cpp | Accepts and validates the optional argument. |
| doc/commands.markdown | Documents options and corrects the unit symbol. |
| CMakeLists.txt | Bumps version to 0.4.0-alpha. |
| .github/workflows/build.yml | Updates checkout, MATLAB, and upload actions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

changes
Openfunctionfixes #16