8000 Add ability to specify "open-options" by ptahmose · Pull Request #19 · ptahmose/MEXlibCZI · GitHub
[go: up one dir, main page]

Skip to content

Add ability to specify "open-options" - #19

Merged
ptahmose merged 15 commits into
masterfrom
jbl/XT
Oct 19, 2026
Merged

ptahmose merged 15 commits into
masterfrom
jbl/XT

Conversation

@ptahmose
@ptahmose ptahmose commented Oct 19, 2026 •
Copy link
Copy Markdown
Owner

changes

  • update to latest version of libCZI
  • add ability to specify 'open-options' for the Open function

fixes #16

ptahmose and others added 14 commits September 28, 2026 14:35
Bump the project version from 0.3.5-alpha to 0.4.0-alpha, switch the libCZI fetch source to ptahmose/libCZI on origin/jbl/XT, and disable building czicmd.
Update build.yml to use actions/checkout@v5, matlab-actions/setup-matlab@v3, and actions/upload-artifact@v5 in build and release jobs without changing workflow logic.
Upgrade `matlab-actions/run-command` to v3 and `actions/upload-artifact` to v7 for MATLAB and Octave MEX artifact uploads. No build logic changed.
Support optional semicolon-separated Open-reader key=value options in `MEXlibCZI('Open', ...)` and `octavelibczi`, pass them through `CziReader::Open` to libCZI, add validation and MATLAB tests, update docs, bump version to `0.5.0-alpha`, and reformat `CziReader.cpp`.
Use `filename.c_str()` in `MexFunction_Open_Execute` when logging the file name with a `%s` formatter, ensuring a C-style string is passed before calling `reader->Open(filename, open_options)`.
Update the test to validate `dimensionSwapWorkaround=XtSubblocks` when opening CZI files.
Validate bounding-box correction with a new CZI fixture while preserving subblock count.
Add an Xztest.czi fixture and MATLAB coverage for opening it with and without the dimension-swap workaround. Leave expected metadata assertions as TODOs.
Updated example usage for MEXlibCZI and corrected unit notation.
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Dependency compatibility and runtime behavior remain unverified, and the XZ regression test lacks behavioral assertions.

1 open issue
What changed in this PR

Adds optional libCZI reader options to support the line-scan workaround described in #16.

Changes:

  • Pass optional Open options through to libCZI and document usage.
  • Add MATLAB tests for XT and XZ dimension workarounds.
  • Pin libCZI, bump the project version, and update build actions.
File Description
tests/​MATLAB/​TestMEXlib_OpenOptions.m Adds dimension-workaround tests.
modules/​libCZI.cmake Pins libCZI to a specific commit.
lib/​src/​implementation/​CziReader.h Declares optional open options.
lib/​src/​implementation/​CziReader.cpp Parses and forwards options; reformats existing code.
lib/​src/​functions/​func_open.cpp Accepts and validates the optional argument.
doc/​commands.markdown Documents options and corrects the unit symbol.
CMakeLists.txt Bumps version to 0.4.0-alpha.
.github/​workflows/​build.yml Updates checkout, MATLAB, and upload actions.

Review effort: Balanced

Comment thread tests/MATLAB/TestMEXlib_OpenOptions.m Resolved
@ptahmose
ptahmose marked this pull request as ready for review October 19, 2026 09:10
@ptahmose
ptahmose merged commit 63a99e5 into master Oct 19, 2026
6 of 8 checks passed
@ptahmose
ptahmose deleted the jbl/XT branch October 19, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems reading line-scanned images

2 participants

0