You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it make sense to prepare pull request with Qt types support? (or at least try to do it)
I believe sfinae magic should be enough for this.
Or library should be stl compatible only? Asking just for saving our time)
What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.
What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.
Yep, but it doesn't look elegant. To open file may be it's fine to use toStdString method. It will be called only once.
But you can't call cell.read_value(qstringobject), you should use std::string and copy value to qString
Moreover I noticed some weird issues with non-ascii symbols in patch -- it leads to crash.
And one more, it looks like implementation not satisfy rfc4180 5.2
Activity
sonulohani commentedon Jan 30, 2021
What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.
ntfshard commentedon Jan 31, 2021
Yep, but it doesn't look elegant. To open file may be it's fine to use
toStdStringmethod. It will be called only once.But you can't call
cell.read_value(qstringobject), you should use std::string and copy value to qStringMoreover I noticed some weird issues with non-ascii symbols in patch -- it leads to crash.
And one more, it looks like implementation not satisfy rfc4180 5.2
sonulohani commentedon Feb 1, 2021
I dont know if the devs are even active here. We can have the fork of this repo to work on the bugs.
ntfshard commentedon Feb 1, 2021
Or use other from fffaraz/awesome-cpp#csv repo
sonulohani commentedon Feb 6, 2021
You could use other. But their could be subtle difference between these libraries. For fast parsing, csv2 is the best.