8000 Add changes for `edge-19.8.2` by scottcarol · Pull Request #3216 · linkerd/linkerd2 · GitHub
[go: up one dir, main page]

Skip to content

Add changes for edge-19.8.2 - #3216

Merged
scottcarol merged 4 commits into
masterfrom
cscott/edge-19.8.2
Aug 8, 2019
Merged

scottcarol merged 4 commits into
masterfrom
cscott/edge-19.8.2

Conversation

@scottcarol
Copy link
Copy Markdown
Contributor

No description provided.

@l5d-bot
l5d-bot commented Aug 8, 2019
Copy link
Copy Markdown
Collaborator

Integration test results for 8d929af: fail 😕
Log output: https://gist.github.com/ed6228bb1fa2f966d1b7317ce3ef35c6

Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
@siggy siggy left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. left some comments around making the bullets more user-facing.

Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
@scottcarol
Copy link
Copy Markdown
Contributor Author

Just pushed changes, would you mind giving the Controller and CLI changes one more look @siggy @ihcsim?

@siggy siggy left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more nits then 🚢 👍

Comment thread CHANGES.md Resolved
Comment thread CHANGES.md Resolved
@l5d-bot
l5d-bot commented Aug 8, 2019
Copy link
Copy Markdown
Collaborator

Integration test results for 9795f6d: success 🎉
Log output: https://gist.github.com/6fc2760eaefa864a91589c1a317dee7a

Comment thread CHANGES.md Resolved
@scottcarol
scottcarol merged commit 0267f01 into master Aug 8, 2019
@scottcarol
scottcarol deleted the cscott/edge-19.8.2 branch August 8, 2019 22:47
@l5d-bot
l5d-bot commented Aug 8, 2019
Copy link
Copy Markdown
Collaborator

Integration test results for 6abb1e9: success 🎉
Log output: https://gist.github.com/aa1ec2c3665f466a7e0bfe9ffb161f68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

0