Repository navigation
Fix bug in service profile name generation - #3209
Merged
Merged
Conversation
Followup to #3148 Wrong args order in call to `profiles.RenderOpenAPI` was generating an invalid service profile name. Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
siggy
approved these changes
Aug 7, 2019
Member
There was a problem hiding this comment.
assuming integration tests pass lgtm
Member
Author
|
Thanks @siggy. Integration tests did pass in my machine 💻 |
Collaborator
|
Integration test results for 654538d: success 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #3148
Wrong args order in call to
profiles.RenderOpenAPIwas generating aninvalid service profile name.