Repository navigation
Add support for service-mirror selectors - #4795
Merged
Merged
Conversation
zaharidichev
approved these changes
Jul 27, 2020
Member
There was a problem hiding this comment.
LGTM! It is nice that this results in completely removing the export-service command
| return Link{}, err | ||
| } | ||
|
|
||
| selector := metav1.LabelSelector{} |
Member
There was a problem hiding this comment.
Maybe worth putting a comment that this piece of code is to exercise the serde rountrip
kleimkuhler
approved these changes
Jul 28, 2020
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
adleong
force-pushed
the
alex/links-awakening
branch
from
July 28, 2020 21:48
dc3e053 to
6f63158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4481
We add support for the source cluster to now specify which services from the target cluster should be exported by using a
label selector rather than looking for the
mirror.linkerd.io/gatewayandmirror.linkerd.io/gateway-nsannotations. Further context for this change is described in linkerd/rfc#31The
Linkresource spec now has aselectorfield which contains a label selector. All services in the target cluster which match this selector will be mirrored. This selector can be set by using the--selectorflag to themulticluster linkcommand and follows the same format as the--selectorflag does in kubectl. The selector can alternatively be set by editing the Link resource directly. If the selector flag tomulticluster linkis left unspecified, it defaults to the selector:mirror.linkerd.io/exported.Some example usage: