Repository navigation
Fetch proxy with specific arch - #4739
Merged
Merged
Conversation
Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
olix0r
reviewed
Jul 13, 2020
olix0r
approved these changes
Jul 13, 2020
Member
There was a problem hiding this comment.
Tested that we can properly update with git-commit-proxy-version
Member
|
@aliariff You can update |
Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
cpretzer
approved these changes
Jul 14, 2020
han-so1omon
pushed a commit
to han-so1omon/linkerd2
that referenced
this pull request
Jul 15, 2020
linkerd/linkerd2-proxy#593 changed the proxy release process to produce platform-specific binaries. This change modifies the bin/fetch-proxy script to fetch amd64-specific binaries. The proxy version has been updated to v1.104.1, which includes no code changes since v1.104.0. Signed-off-by: Ali Ariff <ali.ariff12@gmail.com> Signed-off-by: Eric Solomon <errcsool@engineer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order
2F94
to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpretzer @olix0r
Problem:
The
linkerd2-proxystarting to release artifacts in multi-architecture (linkerd/linkerd2-proxy#593). The naming of the release artifacts now included the architecture name. The current proxy fetcher inlinkerd2repo does not follow that naming convention.Solution:
Adjust the proxy fetcher to retrieve the
amd64version for now.Note:
This PR must be merged after linkerd/linkerd2-proxy#593. And a new release tag will be published for the proxy and adjustment in file
.proxy-versionneed to be made.Signed-off-by: Ali Ariff ali.ariff12@gmail.com