Repository navigation
service topologies: add Kubernetes/API EndpointSlice support - #4696
Merged
Merged
Conversation
Add test data for endpointslice crd Signed-off-by: Matei David <matei.david.35@gmail.com>
Signed-off-by: Matei David <matei.david.35@gmail.com>
Contributor
Author
|
Update: based on the discussion with @adleong in PR#4663 I've changed the return type as well as commented out the two functions responsible for checking whether EndpointSlices can be used. The main assumption we are making is that EndpointSlices should be opt-in for now, as a result, until a mechanism to enable them on a user-by-user basis is put in, the idea is to only use Endpoints (but have the support for the slices in). |
adleong
approved these changes
Jul 6, 2020
Contributor
There was a problem hiding this comment.
Excellent! This looks good to go
adleong
pushed a commit
that referenced
this pull request
Jul 20, 2020
* Small PR that uncomments the `EndpointSliceAcess` method and cleans up left over todos in the destination service. * Based on the past three PRs related to `EndpointSlices` (#4663 #4696 #4740); they should now be functional (albeit prone to bugs) and ready to use. Signed-off-by: Matei David <matei.david.35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the EndpointSlice PR, this is just the k8s/api support for endpointslices to shorten the first PR.
Signed-off-by: Matei David matei.david.35@gmail.com