Repository navigation
Include SMI metrics as part of Linkerd install - #4109
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
|
I don't have strong opinions here, but Should this be an add-on i.e optional? like we did for tracing at #3955 :) |
|
@Pothulapati good question! Since the plan is to eventually switch the CLI and web dashboard over to this API, I think it makes sense to have it as a core component rather than an addon. |
|
@adleong Ah! Makes Sense :) |
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
There was a problem hiding this comment.
Code change LGTM 👍.
What is the plan on managing the divergence from upstream?
There was a problem hiding this comment.
Looks good! Have a quick question about the install process and if we need to account for multi-stage installs.
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
|
@ihcsim This effectively pins our dependency on |
|
@adleong While it's not great that we have to manually merge new YAML and maintain the custom changes in these templates down the road, I can't think of a better way for this atm. I was hoping to write a script that can auto-generate all these smi-metrics templates whenever we need to upgrade to a new version, by using Even adding smi-metrics as a subchart to the Linkerd chart in the |
Adds the SMI metrics API to the Linkerd install flow. This installs the SMI metrics controller deployment, the SMI metrics ApiService object, and supporting RBAC, and config resources. This is the first step toward having Linkerd consume the SMI metrics API in the CLI and web dashboard. Signed-off-by: Alex Leong <alex@buoyant.io>
Adds the SMI metrics API to the Linkerd install flow. This installs the SMI metrics controller deployment, the SMI metrics ApiService object, and supporting RBAC, and config resources.
This is the first step toward having Linkerd consume the SMI metrics API in the CLI and web dashboard. For a sneak peek at that work, try out the
linkerd alpha statcommand in the smi-metrics branch.