Repository navigation
Add spacing in CallToAction banner - #4095
Merged
Merged
Conversation
Contributor
|
This looks good, but looks like the tests were a bit flaky. Try amending the commit, so that the CI Checks are re-run? |
The call to action banner in control plane page is missing some spacing. The CSS is defined but not yet used. So the solution is to add the class name to the corresponding banner. After its merged the banner will have more space. Fixes linkerd#3690 Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
aliariff
force-pushed
the
css-cta-banner
branch
from
February 26, 2020 16:49
dab80ac to
dde7aea
Compare
Contributor
Author
|
@Pothulapati CI passed now. |
scottcarol
reviewed
Feb 26, 2020
Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
ihcsim
approved these changes
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to action banner in the control plane page is missing some spacing.
The CSS is defined but not yet used. So the solution is to add the class name to the corresponding banner.
After its merged, the banner will have more space.
Before:
After:
Fixes #3690
Signed-off-by: Ali Ariff ali.ariff12@gmail.com