[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent C standard and feature flags #847

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TheOneric
Copy link
Member

If someone figures out how to sidestep the array type incompatibility in C99 without additional copies, we can also use c99 everywhere instead.

And add comment explaining why we don't set _POSIX_C_SOURCE
To be used in CI, to verify we don't end up making something non-standard required by accident
This matches autotools and some of our outline related code
is technically invalid in ISO C99 due to passing a “double[3][3]”
to a function expecting a “const double[3][3]”.
This became officially allowed with ISO C23 and was a GNU
extensions for much longer making compilers unlikely to choke on it,
but for now retain gnu99.

MSVC ofc doesn’t support gnu99, but meson will ignore the option and
in fact already ignored c99 for MSVC only honouring c11, c17 and c18.
mesonbuild/meson#7611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant