build: properly spell "Fontconfig", "Core Text", "macOS", "DirectWrite" #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep using "CoreText" without the space when referring to the framework. "macOS" may be a newer name, but "OSX" was never the correct spelling.
These were capitalized for consistency with PKG_CHECK_MODULES, which used to print "checking for VARNAME", but this was changed to "checking for module >= version" or similar in pkg-config 0.29.2 (released 2017-03-20) and pkgconf 1.9.0 (released 2022-08-07).
TheOneric
approved these changes
Oct 15, 2024
astiob
commented
Oct 15, 2024
configure.ac
Outdated
| AC_ARG_ENABLE([directwrite], AS_HELP_STRING([--disable-directwrite], | ||
| [disable DirectWrite support (Windows only) @<:@default=check@:>@])) | ||
| AC_ARG_ENABLE([coretext], AS_HELP_STRING([--disable-coretext], | ||
| [disable CoreText support (OSX only) @<:@default=check@:>@])) | ||
| [disable Core Text support (macOS only) @<:@default=check@:>@])) |
There was a problem hiding this comment.
In fact, this isn’t correct: Core Text is also available on iOS and probably on Apple’s other platforms (watchOS, tvOS…) if libass can be built there at all. Should we change this to “macOS/iOS”? Or something else?
There was a problem hiding this comment.
I usually just say "Apple" (ie "(Apple only)" here).
There was a problem hiding this comment.
Added a commit that switches to “Apple”.
TheOneric
reviewed
Oct 17, 2024
TheOneric
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.