feat: add extractSpectraData function #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `extractSpectraData` to extract all data from an `MSnExp`, `Spectrum` or `MSpectra` as a `DataFrame`. This data could then be passed to the `Spectra` constructor to create a `Spectra` from the original object (see also issue rformassspectrometry/Spectra#123).
|
Quick question before the review: why call this |
|
Hm, good point. Well, mainly because we're actually extracting here also the m/z and intensity values and not just the |
|
No, fine, let's keep it then. The might be an extensive operation for large data, so maybe the name extract will avoid it to be called spuriously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractSpectraDatato extract all data from anMSnExp,SpectrumorMSpectraas aDataFrame. This data could then be passed to theSpectraconstructor to create a
Spectrafrom the original object (see also issueConvert MSnbase::Spectrum2 <-> Spectra object rformassspectrometry/Spectra#123).