8000 Need to implement V2 API in Adam · Issue #16 · lf-edge/adam · GitHub
[go: up one dir, main page]
Skip to content

Need to implement V2 API in Adam #16

New issue
New issue
Open
Open
Need to implement V2 API in Adam#16
Assignees
deitch

Description

@rvs
rvs
opened on May 4, 2020

EVE has transitioned to the V2 API by default. Adam knows only about V1 still. This means we have to force all instances of EVE that talk to Adam to have Force-API-V1 in the config folder -- otherwise EVE won't be able to talk to Adam at all.

There's work in EVE going on to publish V2 API spec updates -- once that is done we'll use the spec to update Adam to V2 API.

Activity

  1. rvs
    assigned
    deitch
    on May 4, 2020
  2. rvs
    added 2 commits that reference this issue on May 5, 2020

    Forcing EVE to use V1 API while lf-edge#16 is getting fixed

    0a12f4e

    Forcing EVE to use V1 API while lf-edge#16 is getting fixed

    2b6af63

  3. deitch commented on May 5, 2020

    @deitch
    deitch
    on May 5, 2020
    Contributor

    @rvs not sure I understand this. Is the below correct?

    • eve can talk v1 and v2, but uses v2 by default
    • if eve receives a particular signal on onboarding, it falls back to v1
    • what is that signal?
    • can other controllers (zedcloud) talk both?
    • can and should we get adam to talk both?
    • since the api is driven by generated protobuf files, how do they coexist?
  4. rvs
    added a commit that references this issue on May 5, 2020

    Forcing EVE to use V1 API while #16 is getting fixed

    acfb407

  5. rvs commented on May 5, 2020

    @rvs
    rvs
    on May 5, 2020
    ContributorAuthor

    Hey @deitch -- here's the deal:

    eve can talk v1 and v2, but uses v2 by default

    correct -- in addition to that there's an agreement that v1 support goes away soon (once Adam gets a chance to catch up basically)

    if eve receives a particular signal on onboarding, it falls back to v1

    nope -- onboarding itself is part of the API hence we can't use that as a signal -- the only we can give EVE to fallback onto V1 is that file in /config

    can other controllers (zedcloud) talk both?

    Zedcloud is in a process of transitioning to V2 only

    can and should we get adam to talk both?

    there's not really much value, since EVE is going to drop V1 the moment Adam can support V2

    since the api is driven by generated protobuf files, how do they coexist?

    The API are on different endpoints

    @eriknordmark and Naiming are documenting all of this in this current sprint

  6. deitch commented on May 6, 2020

    @deitch
    deitch
    on May 6, 2020
    Contributor

    onboarding itself is part of the API hence we can't use that as a signal -- the only we can give EVE to fallback onto V1 is that file in /config

    That aligns with what you did in #17 ; makes sense.

    Zedcloud is in a process of transitioning to V2 only
    The API are on different endpoints

    So we are just moving to v2 and retiring v1. Fine with me.

    @eriknordmark and Naiming are documenting all of this in this current sprint

    So the position is that we hold until that is documented, then implement it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
    0