8000 [pull] master from spulec:master by pull[bot] · Pull Request #481 · levinine/moto · GitHub
[go: up one dir, main page]

Skip to content

[pull] master from spulec:master - #481

Open
pull[bot] wants to merge 4706 commits into
levinine:masterfrom
getmoto:master
Open

pull[bot] wants to merge 4706 commits into
levinine:masterfrom
getmoto:master

Conversation

@pull
@pull pull Bot commented Nov 22, 2021 •
Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

github-actions Bot and others added 28 commits September 5, 2026 01:09
The guard for real AWS requests also applies to Moto because
the ec2 tests run in parallel.
EC2 tests are run in parallel with MOTO_EC2_LOAD_DEFAULT_AMIS set to False,
which was causing some of these tests to become flaky in CI runs when the
environment variable was set to False on another thread after the patch.
For testing, provides a 90-second validation window to help fix
some flaky tests that were failing due to server-client clock drift
or strict (30 second) time-window enforcement.

Note: behavior is unchanged for regular Moto usage, though we may
want to enable the windowed check via a setting if the need arises.
Implements the ECR image-layer push flow that previously raised
NotImplementedError:

- initiate_layer_upload
- upload_layer_part
- complete_layer_upload
- batch_check_layer_availability

InitiateLayerUpload returns an uploadId and part size; parts are accumulated
per upload and CompleteLayerUpload derives the layer digest from the uploaded
bytes (sha256) and stores the layer on the repository. BatchCheckLayerAvailability
reports AVAILABLE layers and returns MissingLayerDigest/InvalidLayerDigest
failures otherwise. Adds an UploadNotFoundException for unknown upload ids and
acceptance tests covering the full flow and error cases.
Cloud Map lets you attach custom key/value attributes to a service via
get/update/delete_service_attributes, but those three weren't mocked yet.

The attributes now live on the Service, updates merge into whatever is
already there, and going past the 30-attribute limit raises
ServiceAttributesLimitExceededException like the real API does.
Co-authored-by: Brian Pandola <bpandola@gmail.com>
Co-authored-by: Brian Pandola <bpandola@gmail.com>
Co-authored-by: Brian Pandola <bpandola@gmail.com>
bpandola and others added 30 commits November 4, 2026 19:29
The docs don't say what the default page size is, but 2147483647
is listed as the maximum allowed and clearly shouldn't be the default,
so it has been changed to 50.

A basic pagination test for each affected endpoint is added.  These
tests use the boto3 paginator to ensure the pagination succeeds in
a case where multiple pages are needed to get the full result set.
CloudFront reports a finished invalidation as "Completed", and the
InvalidationCompleted waiter in botocore and the AWS SDKs matches that
exact string. Moto returned "COMPLETED", so the waiter never succeeded.
create_distribution and update_distribution dropped the
OriginAccessControlId of each origin, so get_distribution and
get_distribution_config never returned it. Store it and return it,
defaulting to "" like CloudFront does for origins without one.
The origin's S3OriginConfig was validated and its OriginAccessIdentity
kept in s3_access_identity, but never returned, because the serializer
looks for s3_origin_config. A client that reads the config with
get_distribution_config, changes it and sends it back with
update_distribution therefore lost the S3 origin settings. Keep the
S3OriginConfig as given so it round-trips.
Latest botocore release adds CBOR to the list of supported protocols
for the Resource Groups Tagging API service, so we need to supply
an appropriate content-type header for wire protocol identification.
Several tests used 1-2s visibility timeouts, which intermittently
failed on slow CI runners. Timeouts (and the matching sleep calls)
have been bumped up to 5s.  SQS tests are run in parallel, so this
won't increase the time it takes to run the full suite.

A number of "VisibilityTimeout " typos (trailing space) have also
been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0