[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos for code notes. #1653

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix some typos for code notes. #1653

merged 1 commit into from
Dec 7, 2023

Conversation

yanggangtony
Copy link
Contributor

Fixes #

Proposed Changes

Fix some typos for code notes.
*
*
*

Release Note

None

Fix some typos for code notes.
cb96171 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2023
@knative-prow Knative Prow
Copy link
knative-prow bot commented Dec 7, 2023

Welcome @yanggangtony! It looks like this is your first PR to knative/operator 🎉

@knative-prow Knative Prow
Copy link
knative-prow bot commented Dec 7, 2023

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2023
matzew
matzew approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member
@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/ok-to-test

Thanks for this @yanggangtony

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 7, 2023
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2023
@knative-prow Knative Prow
Copy link
knative-prow bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, yanggangtony

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@codecov Codecov
Copy link
codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (124c758) 79.37% compared to head (cb96171) 79.37%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files          41       41           
  Lines        1857     1857           
=======================================
  Hits         1474     1474           
  Misses        279      279           
  Partials      104      104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit cfea599 into knative:main Dec 7, 2023
25 checks passed
@yanggangtony yanggangtony deleted the fix-typo-notes branch December 7, 2023 21:47
ReToCode
ReToCode reviewed Dec 8, 2023
View reviewed changes
pkg/apis/operator/register.go
@@ -37,7 +37,7 @@ var (
Group: GroupName,
Resource: "knativeservings",
}
// KnativeServingResource respresents a Knative Serving
// KnativeEventingResource respresents a Knative Serving
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanggangtony you probably also want to change Knative Serving to Knative Eventing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, have no seen the last words...
I just update the First outstanding word!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do it in next clean code.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode left review comments

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@houshengbo houshengbo Awaiting requested review from houshengbo

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanggangtony @matzew @ReToCode