[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make was not called #2234 #2245

Merged
merged 1 commit into from
Mar 27, 2024
Merged

make was not called #2234 #2245

merged 1 commit into from
Mar 27, 2024

Conversation

matzew
Copy link
Member
@matzew matzew commented Mar 25, 2024

Changes

  • the make seems to be forgotten often, running it after 2234 PR

/kind

Fixes #

Release Note


Docs


Copy link
knative-prow bot commented Mar 25, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • the make seems to be forgotten often, running it after 2234 PR

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2024
@matzew
Copy link
Member Author
matzew commented Mar 25, 2024

@lkingland @matejvasek can we make this more intuitive ? Either by a CI linter, or something?

@lkingland
Copy link
Member
lkingland commented Mar 26, 2024

@lkingland @matejvasek can we make this more intuitive ? Either by a CI linter, or something?

Yes, we can, and we should 👍🏻 A little background:

Make may actually have been called, because the actual root problem that causes this most often (though perhaps not in this PR) is that the task which updates docs is not properly clearing its environment, so if (like me) you have FUNC_ENABLE_HOST_BUILDER=true or anything in your global config which alters command default options, the docs are all updated on make to include those differences. This means I am perpetually confronted with unstaged changes in ./docs, and forget that sometimes the changes are valid and need to be checked in. I presume this happens for others as well.

The ideal fix here is probably twofold: 1) fix the docs generator to clear its environment before generating docs and then 2) have a CI task which (like we do for zz_filesystem_generated) fail in CI if there are unstaged changes in ./docs after building.

Copy link
Member
@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link
knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7914454 into knative:main Mar 27, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants