-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make was not called #2234 #2245
Conversation
@matzew: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lkingland @matejvasek can we make this more intuitive ? Either by a CI linter, or something? |
Yes, we can, and we should 👍🏻 A little background: Make may actually have been called, because the actual root problem that causes this most often (though perhaps not in this PR) is that the task which updates The ideal fix here is probably twofold: 1) fix the docs generator to clear its environment before generating docs and then 2) have a CI task which (like we do for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
make
seems to be forgotten often, running it after 2234 PR/kind
Fixes #
Release Note
Docs