[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in run cmd #2168

Merged
merged 1 commit into from
Feb 16, 2024
Merged

typo in run cmd #2168

merged 1 commit into from
Feb 16, 2024

Conversation

Sanket-0510
Copy link
Contributor

Changes

-fixes typo in run command long description

/kind

Fixes #2167

Release Note

Docs

@knative-prow Knative Prow
Copy link
knative-prow bot commented Feb 16, 2024

@Sanket-0510: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

-fixes typo in run command long description

/kind

Fixes #2167

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2024
@knative-prow Knative Prow
Copy link
knative-prow bot commented Feb 16, 2024

Welcome @Sanket-0510! It looks like this is your first PR to knative/func 🎉

@knative-prow Knative Prow
Copy link
knative-prow bot commented Feb 16, 2024

Hi @Sanket-0510. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor

/ok-to-test
/approve
/lgtm

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 16, 2024
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2024
@knative-prow Knative Prow
Copy link
knative-prow bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, Sanket-0510

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@codecov Codecov
Copy link
codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d04b7ad) 64.19% compared to head (a0a3565) 65.16%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
+ Coverage   64.19%   65.16%   +0.97%     
==========================================
  Files         108      108              
  Lines       13918    13918              
==========================================
+ Hits         8934     9070     +136     
+ Misses       4110     3950     -160     
- Partials      874      898      +24
Flag Coverage Δ
e2e-test 37.37% <100.00%> (+0.05%) ⬆️
e2e-test-oncluster 30.59% <100.00%> (+0.10%) ⬆️
e2e-test-oncluster-runtime 26.83% <100.00%> (?)
e2e-test-runtime-go 25.55% <100.00%> (?)
e2e-test-runtime-node 26.57% <100.00%> (?)
e2e-test-runtime-python 26.57% <100.00%> (?)
e2e-test-runtime-quarkus 26.68% <100.00%> (?)
e2e-test-runtime-rust 25.58% <100.00%> (?)
e2e-test-runtime-springboot 25.71% <100.00%> (?)
e2e-test-runtime-typescript 26.68% <100.00%> (?)
integration-tests 51.81% <100.00%> (+2.01%) ⬆️
unit-tests-macos-latest 48.84% <100.00%> (ø)
unit-tests-ubuntu-latest 49.59% <100.00%> (+0.02%) ⬆️
unit-tests-windows-latest 48.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit d2fb76c into knative:main Feb 16, 2024
42 checks passed
@Sanket-0510 Sanket-0510 deleted the typo-in-run branch February 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

@vyasgun vyasgun Awaiting requested review from vyasgun

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in run command
2 participants
@Sanket-0510 @matejvasek