[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth syntax and pass only in the filters not the entire config #2115

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Smooth syntax and pass only in the filters not the entire config #2115

merged 1 commit into from
Jan 12, 2024

Conversation

matzew
Copy link
Member
@matzew matzew commented Jan 11, 2024

Changes

  • 🧹 Update syntax and pass on only the slice

/kind

Fixes #

Release Note

Docs

@knative-prow Knative Prow
Copy link
knative-prow bot commented Jan 11, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Update syntax and pass on only the slice

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from gauron99 and rhuss January 11, 2024 09:55
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2024
@codecov Codecov
Copy link
codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f44e71) 63.10% compared to head (0e44f84) 65.16%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2115      +/-   ##
==========================================
+ Coverage   63.10%   65.16%   +2.05%     
==========================================
  Files         108      108              
  Lines       13870    13870              
==========================================
+ Hits         8753     9038     +285     
+ Misses       4275     3940     -335     
- Partials      842      892      +50
Flag Coverage Δ
e2e-test 37.30% <100.00%> (-0.01%) ⬇️
e2e-test-oncluster 30.58% <0.00%> (?)
e2e-test-oncluster-runtime 26.83% <0.00%> (?)
e2e-test-runtime-go 25.58% <0.00%> (?)
e2e-test-runtime-node 26.57% <0.00%> (?)
e2e-test-runtime-python 26.57% <0.00%> (?)
e2e-test-runtime-quarkus 26.69% <0.00%> (?)
e2e-test-runtime-rust 25.58% <0.00%> (?)
e2e-test-runtime-springboot 25.71% <0.00%> (?)
e2e-test-runtime-typescript 26.69% <0.00%> (?)
integration-tests 51.82% <100.00%> (+2.03%) ⬆️
unit-tests-macos-latest 48.75% <100.00%> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.52% <100.00%> (ø)
unit-tests-windows-latest 48.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Smooth syntax
0e44f84 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@knative-prow Knative Prow
Copy link
knative-prow bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@knative-prow knative-prow bot merged commit 2ebaf57 into knative:main Jan 12, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@gauron99 gauron99 Awaiting requested review from gauron99

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @lkingland