[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix s2i on cluster RT tests #2015

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fix s2i on cluster RT tests #2015

merged 3 commits into from
Oct 12, 2023

Conversation

matejvasek
Copy link
Contributor
@matejvasek matejvasek commented Oct 11, 2023 •
edited
Loading

Fix s2i on cluster RT tests.

  • Use smaller s2i builder image for nodejs
  • Skip python s2i on cluster build when running in GH action
chore: using nodejs-16-minimal instead of nodejs-16 as default builder for JS/TS

@matejvasek
chore: use smaller s2i nodejs builder
da93f09 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
test: skip python s2i on cluster build test on GH
4811c85 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2023
@knative-prow knative-prow bot requested a review from gauron99 October 11, 2023 15:24
@knative-prow
Copy link
knative-prow bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@matejvasek
fixup: do check at correct place
312433a 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@codecov
Copy link
codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7b09bcd) 54.12% compared to head (312433a) 60.66%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
+ Coverage   54.12%   60.66%   +6.54%     
==========================================
  Files         105      106       +1     
  Lines       13691    13693       +2     
==========================================
+ Hits         7410     8307     +897     
+ Misses       5520     4548     -972     
- Partials      761      838      +77
Flag Coverage Δ
e2e-test 36.46% <ø> (?)
e2e-test-oncluster 30.42% <ø> (-0.03%) ⬇️
e2e-test-oncluster-runtime 26.72% <ø> (?)
e2e-test-runtime-go 25.50% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.50% <ø> (?)
e2e-test-runtime-springboot 25.70% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
unit-tests-macos-latest 48.21% <ø> (?)
unit-tests-ubuntu-latest 48.98% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 48.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/builders/s2i/builder.go 64.17% <ø> (+3.54%) ⬆️

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gauron99
gauron99 reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor
@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot merged commit f83c0ee into knative:main Oct 12, 2023
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauron99 gauron99 gauron99 left review comments

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@jrangelramos jrangelramos

@gauron99 gauron99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @jrangelramos @gauron99