[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version source #1933

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fix version source #1933

merged 1 commit into from
Aug 15, 2023

Conversation

lkingland
Copy link
Member

🐛 default source-built version to v0.0.0+source

Fixes:

❯ go build ./cmd/func
❯ ./func version
%!v(PANIC=String method: Invalid Semantic Version)

To be:

❯ go build ./cmd/func
❯ ./func version
v0.0.0+source

a syntactically valid semver using the metadata suffix to hint this was a source-direct build.

/kind bug

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2023
@knative-prow knative-prow bot requested review from dsimansk and rhuss August 15, 2023 05:19
@codecov
Copy link
codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: +2.02% 🎉

Comparison is base (1163a5e) 60.69% compared to head (9845042) 62.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1933      +/-   ##
==========================================
+ Coverage   60.69%   62.71%   +2.02%     
==========================================
  Files         107      107              
  Lines       13819    13825       +6     
==========================================
+ Hits         8387     8670     +283     
+ Misses       4603     4273     -330     
- Partials      829      882      +53
Flag Coverage Δ
e2e-test 35.49% <0.00%> (-0.02%) ⬇️
e2e-test-oncluster-runtime 25.65% <0.00%> (?)
e2e-test-runtime-go 25.91% <0.00%> (?)
e2e-test-runtime-node 26.94% <0.00%> (?)
e2e-test-runtime-python 26.94% <0.00%> (?)
e2e-test-runtime-quarkus 27.05% <0.00%> (?)
e2e-test-runtime-rust 25.94% <0.00%> (?)
e2e-test-runtime-springboot 26.07% <0.00%> (?)
e2e-test-runtime-typescript 27.05% <0.00%> (?)
integration-tests 51.50% <50.00%> (+2.20%) ⬆️
unit-tests-macos-latest 48.27% <50.00%> (+<0.01%) ⬆️
unit-tests-ubuntu-latest 49.06% <50.00%> (+<0.01%) ⬆️
unit-tests-windows-latest 48.31% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/root.go 81.38% <50.00%> (-0.84%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@knative-prow
Copy link
knative-prow bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4927827 into knative:main Aug 15, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkingland @matejvasek