[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kn secret command #1791

Merged
merged 5 commits into from
Apr 24, 2023
Merged

Add kn secret command #1791

merged 5 commits into from
Apr 24, 2023

Conversation

dsimansk
Copy link
Contributor
@dsimansk dsimansk commented Mar 21, 2023 •
edited
Loading

Description

Changes

  • 🎁 kn secret cmd group

Reference

Fixes #287

Release Note

Add `kn secret` commands group for managing secrets

PTAL do you recall this feature? :)
/cc @rhuss

@knative-prow knative-prow bot requested a review from rhuss March 21, 2023 16:30
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2023
@codecov
Copy link
codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 62.57% and project coverage change: -0.18 ⚠️

Comparison is base (7586217) 79.87% compared to head (59c6fb7) 79.70%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   79.87%   79.70%   -0.18%     
==========================================
  Files         174      179       +5     
  Lines       13593    13850     +257     
==========================================
+ Hits        10858    11039     +181     
- Misses       1992     2050      +58     
- Partials      743      761      +18
Impacted Files Coverage Δ
pkg/kn/commands/types.go 82.60% <23.07%> (-5.23%) ⬇️
pkg/kn/commands/secret/create.go 53.12% <53.12%> (ø)
pkg/kn/commands/secret/list.go 70.96% <70.96%> (ø)
pkg/kn/commands/secret/delete.go 71.42% <71.42%> (ø)
pkg/kn/commands/secret/secret.go 100.00% <100.00%> (ø)
pkg/kn/root/root.go 90.00% <100.00%> (+0.08%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vyasgun
vyasgun requested changes Apr 24, 2023
View reviewed changes
pkg/kn/commands/secret/create.go Outdated Show resolved Hide resolved
pkg/kn/commands/secret/create.go Outdated Show resolved Hide resolved
pkg/kn/commands/secret/delete_test.go Outdated Show resolved Hide resolved
pkg/kn/commands/secret/secret.go Outdated Show resolved Hide resolved
pkg/kn/commands/secret/secret_test.go Outdated Show resolved Hide resolved
@vyasgun
Copy link
Contributor
vyasgun commented Apr 24, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2023
@knative-prow
Copy link
knative-prow bot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1231cd2 into knative:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasgun vyasgun vyasgun requested changes

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@vyasgun vyasgun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kn secret for managing secrets
2 participants
@dsimansk @vyasgun