Repository navigation
V0-17: Complete macOS keyboard, accessibility, and external links - #37
Merged
Merged
Conversation
Issue #18. Complete the keyboard, accessibility, focus, reduced-motion, and external-link behavior across the finished V0 surfaces. Shortcuts and Escape: - Command-K opens a command palette (cmdk) that runs the actions App already owned; the palette learns no business rule. - Command-Z session undo already skipped text editing; unchanged. - Escape is now coordinated by a priority-ordered escape stack so the topmost dismissible surface (palette > modal > inline draft) closes before the note-focus lock clears. The note-focus lock demoted to the lowest priority. Modals and focus: - useModalFocus traps focus inside a true modal, cycles Tab within it, and restores focus to the invoker on close. Applied to the Cloud consent disclosure, the Rename Label dialog, and the command palette. - Inline note-card and workspace-rename forms cancel on Escape via a shared EscapeDismiss component. External links: - A Note's Markdown links never navigate the webview: the ReactMarkdown `a` override routes explicit http/https URLs through one Tauri command that re-validates the scheme in Rust and hands the URL to the macOS `open` shell opener. Non-HTTP(S) schemes render as inert text. The single durable seam (workspace-client) gains one binding; no new Tauri plugin or capability. Status, reduced motion, and visible focus: - The over-limit Annotation counter reads "Over the limit" (role=alert), not color alone. Synthesis and enrichment status get aria-live; the consent dialog announces its saving state. - A defensive prefers-reduced-motion media query neutralises animation without hiding state (V0 has no essential animation). - Global :focus-visible ring for every interactive control. Tests: - User-level keyboard, accessibility, focus-trap, external-link, scheme rejection, reduced-motion, and "don't steal shortcuts" integration tests. - Rust unit tests for the external-link scheme predicate. - vitest now excludes stale agent-worktree checkouts under .claude/. Workflow: prd-simplicity-audit (docs/audits/issue-18-simplicity-audit.md, PROCEED), parallel Standards+Spec code-review (findings addressed), scoped fallow (no introduced dead code/duplication; App complexity threshold documented as pre-existing orchestrator debt), and the full check gate (typecheck, lint, vitest, cargo test, web build, cargo check).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.
2F77
Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18. Part of #1.
What this does
Completes the macOS keyboard, accessibility, focus, reduced-motion, and external-link behavior across the finished V0 surfaces.
EscapeDismiss.aoverride routes explicit http/https URLs through one Tauri command that re-validates the scheme in Rust (external_link.rs) and hands the URL to the macOSopenshell opener. Non-HTTP(S) schemes render as inert text. The single durable seam (workspace-client) gains one binding; no new Tauri plugin or capability.role=alert); Synthesis/Enrichment status arearia-live; the consent dialog announces its saving state.prefers-reduced-motionmedia query neutralises animation without hiding state (V0 has no essential animation).:focus-visiblering for every interactive control.New modules
src-tauri/src/external_link.rs— scheme validation (pure, unit-tested) + macOS shell opener.src/escape-stack.ts— coordinated Escape priority.src/modal-focus.ts— focus trap + restore-to-invoker.src/command-palette.tsx— Command-K palette +useCommandPaletteShortcut.src/external-link.tsx— ReactMarkdownaoverride.src/escape-dismiss.tsx— shared inline-form Escape cancellation.Workflow followed
Per
AGENTS.md:prd-simplicity-audit(docs/audits/issue-18-simplicity-audit.md, PROCEED) → parallel Standards + Spec code-review (all actionable findings addressed) → scoped fallow (no introduced dead code or duplication; the one introduced complexity regression in App was extracted into a module-level buildPaletteActions and the remaining single conditional render is documented as pre-existing orchestrator debt out of scope for this slice) → focused tests + full check gate.Gates
fallow audit --base HEAD: introduced dead-code 0, introduced complexity 0, introduced duplication 0. The 44 inherited dead-code errors are pre-existing legacy-scaffold dependencies, out of scope.Manual VoiceOver smoke pass (automation cannot prove these)
Please verify on a macOS build:
Do not merge without review.