Repository navigation
Rail modes: Findings and Judge - #84
Merged
Merged
Conversation
The Rail opens on Findings each session, with the Band control, All, the run controls and the queue first; Judge mode holds the Judge with milestones and Revisions. The queue keys act only in Findings mode and the modifier step switches to it. The live region sits outside both modes. The hint bar is one line at the Rail's foot; the full text is on the shortcuts page. The raw-response option moves to AI Settings as the stored showRawResponse key. Only the Current Finding's row shows model and time; the Callout shows them for each Finding. Rail headings step up to a three-step type scale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #57. Closes #66.
What changed
src/editor/railTabs.ts):RailMode = "findings" | "judge",RAIL_MODESandINITIAL_RAIL_MODE. The Rail keeps the mode in local state and never stores it. The switch is a tablist at the top of the Rail, with arrow and Home/End keys, and the Findings tab shows the open count. Both mode panels stay mounted and the one not showing ishidden, so the Judge's chosen Revisions and a Rule config being edited survive a mode switch.src/editor/queueKeys.ts):queueActionFor(event, railMode)now returns{ action, switchToFindings } | null. In Judge mode it returns nothing except the Alt-arrow step, and that step comes back withswitchToFindings: true.?key cap that opens How this works at Shortcuts. The shortcuts section gains a paragraph saying the keys act only in Findings mode and that Alt switches the Rail to Findings.showRawResponse(src/storage/settings.ts): a new key in the existingsettingsstore. It defaults to off, and only an explicittrueturns it on. It flows throughuseGlobalSettings,useDocumentand App, and is set from a checkbox in AI Settings under Runs. The Rail's own checkbox is gone.FindingCallout.tsx; its buttons and hints are untouched.CONTEXT.mdadds Rail mode and updates Rail. The in-app glossary does the same.Decisions to review
v1.3the whole page scrolls with the Rail, because the root ismin-h-screen. I made the mode switch and the hintsticky, so the switch stays one click away and the hint stays at the visible foot. I did not change the page layout inApp.tsx.Acceptance criteria
queueKeys.test.tscovers "queueActionFor and the Rail mode": in Judge mode plain keys return nothing, typing or not, and Alt+↓/↑ returns the step withswitchToFindings. Checked in the app as well: in Judge modejandachanged nothing, and Alt+↓ from inside the prose switched to Findings and moved the Current Finding.showRawResponsesaves, loads and normalises (tested); the AI Settings toggle shows raw responses on rows. In headless Chromium I seeded a stored run response for an existing Finding, because there is no model Run without a key. It was not shown before the toggle, was shown on rows after turning it on in AI Settings, and was still on after a reload.role=statuslive region is outside#rail-mode-findings,#rail-mode-judgeand the Rail itself, and it is driven by the existingannouncementForTransitionwhatever the mode.j, exactly one row showed "rule · date"; the Callout showed it for its Finding.Also
pnpm test(1082 passing),pnpm typecheck,pnpm run gatesandpnpm buildall pass.docs/adr/0012-the-judge-is-a-rail-mode.mdas superseding one sentence of ADR 0010 (the Judge "below the Bands"), but it was never committed. This PR follows the spec, keeps ADR 0010's four properties, and does not write the ADR.🤖 Generated with Claude Code
Generated by Claude Code