Repository navigation
Header destinations and the Callout's verdicts - #82
Merged
Merged
Conversation
Editor and Library are the header's tabs; the Pass workbench and AI Settings follow as quieter links; How this works and Privacy sit under one help control that opens from the keyboard and closes on Escape, returning focus. Every destination is at most two clicks from every other, tested as a rule on the destination model. The header wraps instead of scrolling sideways, so it no longer clips the Document menu. In the Callout, Addressed is a filled button, Decline an outlined one and Decline as violation a text link. It carries no key hints (ADR 0011). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #57. Closes #68.
What changed
text-sm, with the current one filled in ink. The Pass workbench and AI Settings come next as quietertext-xslinks, and the current one is underlined. How this works and Privacy sit under one Help control (src/HelpMenu.tsx). It works as a disclosure: Enter or Space opens it, its two destinations come next in the tab order, and Escape closes it and returns focus to the button. A press outside, focus leaving it, or any change of destination (including?) also closes it. The control reads as current while How this works or Privacy is open.src/navigation.tsgives each destination aplacement(tab/link/help), plus three pure functions:destinationsAt,isHelpCurrent, andclicksBetween(from, to)for story 247. They are tested insrc/navigation.test.ts, including a test that every pair of destinations is at most two clicks apart.overflow-x-auto, which clipped the Document menu at 1440px. It now wraps (flex-wrap) instead of scrolling sideways, so neither the Document menu nor the Help list is clipped. The divider after Document is hidden belowsm, where the header wraps.focus-visible:ring-offset-2. Decline is an outlined button, and Decline as violation is an underlined text link. It still appears only when the Finding carries a violation. The Callout has no key hints. It had none before this PR, and a comment now records why (ADR 0011).No colour tokens were added and
src/index.cssis untouched. No Dexie migration, the findings schema is unchanged, no affordance inserts model-derived text, and there is no DOM test layer. The title field, toolbar and Status line are untouched.Acceptance criteria
clicksBetween.?still opens the shortcuts. Verified in headless Chromium in both schemes. Pressing?from the Library opened How this works with the Shortcuts heading in view, and the Help control read as current.pnpm test(79 files, 1073 tests),pnpm typecheck,pnpm run gatesandpnpm buildall pass.🤖 Generated with Claude Code
Generated by Claude Code