Repository navigation
Move the Rail to colour names, with focus rings - #80
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Every Rail panel now uses the colour names from index.css instead of palette classes. The Milestone badge takes a violet milestone pair, no longer the warning amber (story 208). The Raw response and Milestones only checkboxes, the milestone note and the Rail's tab panel gain the shared focus ring (story 209). Part of #57. Closes #60. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
A ring in the focus colour with no offset disappears against an ink fill, so Flag this revision, Judge, the active Judge toggles and the rule config Save button carry ring-offset-2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
A failed model Run, a failed Reader or Audit Run and a failed Judge call report something that went wrong, so they take failure rather than warning (spec #57: amber for warnings, red for failures). Advisory notices stay warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
kiran-brahma
force-pushed
the
v1.3-60
branch
from
September 26, 2026 09:56
029b204 to
f12eef8
Compare
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #57. Closes #60.
Batch 2 of the colour refactor. Every palette class in the Rail's files (WorkingOrderRail, BandPanel, FindingRow, FindingsSidebar, JudgePanel, MetricsPanel, OutlinePanel, RuleConfigEditor, RulePassesPanel, ViolationDisplay, AccountDisplay; ElapsedTimer had none) now uses the colour-name table in
src/index.css, including its context-dependent entries: the Current Finding's row ismark-wash, the Judge's word diff isadded/added-inkandremoved/removed-ink, and agreement isagreement-*.--color-milestoneand--color-milestone-inkchanged, from amber-200/amber-900 to violet-200/violet-900 (Tailwind's oklch values, copied exactly). The badge now usestext-milestone-ink. Text on the badge measures 7.95:1 (it was 7.28:1). No other token was added or changed.focus:outline-noneand nothing else) and the focusable Rail tab panel (inset, sooverflow-y-autocan't clip it). The ink-filled controls (Flag this revision, Judge, the active Judge toggles, and the rule config Save button) getfocus-visible:ring-offset-2.border-failure-rule bg-failure-surface text-failure.text-failureonfailure-surfacemeasures 5.87:1.WorkingOrderRail,handle.runError), the Reader Pass Run error (BandPanel,ReaderPassBlock), the Audit Run error (BandPanel), and the Judge error (JudgePanel). The Cancel run button already used the failure colours.WorkingOrderRail); a solo rule pass is holding the others (BandPanel,RulePassesPanel); assign a critic and a judge connection (JudgePanel); the same-model warning (JudgePanel); a Prediction the Judge disagreed with (JudgePanel); an Unstable verdict (JudgePanel).v1.3(Move the other screens to colour names, type scale and focus rings #61 merged).Acceptance criteria
bg|text|border|ring|divide|decoration-<palette>class and nobg-white.v1.3before this change, the tab panel and the milestone note showed no ring and the checkboxes showed only the browser's default outline. The Pass checkboxes in the Band panels already had rings, which I checked in source only.v1.3, in the Structure, Paragraph, Word and All modes and after flagging a milestone. The only difference beyond 1/255 per channel was the Milestone badge. That comparison ran before the failure recolour, which changes the four failure notices on purpose, as the spec requires. Not exercised in the app: the Current Finding row, Judge results, Prediction agreement, run-error notices and Violation display. These need a Connection or a model Run, so they are verified only through the class-to-name mapping.pnpm test(1021 passed),pnpm typecheck,pnpm run gatesandpnpm buildall pass.No affordance inserts model-derived text. No Worker route was added, and there is no Dexie migration or DOM test layer. The findings schema is unchanged, and no Highlight styling was touched.
🤖 Generated with Claude Code