8000 Colour names with today's colours by kiran-brahma · Pull Request #77 · kiran-brahma/writing-tool · GitHub
[go: up one dir, main page]

Skip to content

Colour names with today's colours - #77

Merged
kiran-brahma merged 2 commits into
v1.3from
v1.3-58
Sep 26, 2026
Merged

kiran-brahma merged 2 commits into
v1.3from
v1.3-58

Conversation

@kiran-brahma
@kiran-brahma kiran-brahma commented Sep 26, 2026 •
Copy link
Copy Markdown
Owner

Part of #57. Closes #58.

The expand step of the colour refactor. Only src/index.css changes:

Components are unchanged. The palette classes still work, and no dark values are defined.

The names

  • The ticket's nine, spelled as listed: paper, ink, muted-ink, rule, mark, current-mark, warning, failure, milestone.
  • Surfaces: ground (stone-50, the app behind the page), sunk (stone-100), sunk-strong (stone-200).
  • Ink, strongest to faintest: ink, soft-ink, quiet-ink, muted-ink, faint-ink, ghost-ink (stone-900 down to stone-400). Also on-ink for text on an ink fill.
  • Rules: rule-faint, rule-soft, rule, rule-strong, rule-focus (stone-100 to stone-500), and focus for the stone-600 focus ring.
  • The mark: mark-line, mark-hover, current-mark-line, and mark-wash (amber-100, the Current Finding's row).
  • Warning: warning-soft, warning-muted, warning-focus, warning-surface, warning-rule, warning-rule-strong.
  • Milestone: milestone-ink, the badge's text. The badge can then stop borrowing warning's amber (story 208) without touching warning.
  • Failure: failure-surface, failure-rule, failure-focus. And success (emerald-700, a Connection test that passed).
  • The Judge: agreement, agreement-surface, agreement-rule for a Prediction the Judge agreed with. added, added-ink, removed and removed-ink for its word diff.
  • A Violation: violation (the strike), violation-ink, violation-surface, violation-wash, violation-rule, violation-focus.
  • Links: link and link-hover for the tool's own text, and prose-link for the Writer's prose.

Opacity modifiers carry over unchanged: bg-stone-100/60 becomes bg-sunk/60.

Every palette class has one stable meaning, with three contextual cases the table spells out:

  • text-amber-900 is warning in general, but milestone-ink on the milestone badge.
  • text-amber-50 on the warning-filled Restore button is warning-surface.
  • text-stone-100 on the raw-response ink/90 block is sunk, the same pairing the Editor's code block uses.

Two places where one name cannot equal both of today's colours:

  • Links: the Editor's link hex is #1d4ed8 (Tailwind v3's blue-700). The palette class text-blue-700 is v4's oklch value, which renders #1447e6, a visibly brighter blue. So they get two names, prose-link and link. A later batch can unify them deliberately.
  • muted-ink: it keeps the Editor's #57534e. text-stone-600 renders #57534d, one unit off in the blue channel. That is not visible, so I chose one name over two.

Acceptance criteria

  • Every name exists as a theme colour usable from utility classes. I compiled index.css with Tailwind's compiler. It generates bg-, text- and border- utilities for the nine required names.
  • The Editor stylesheet uses only names, with no literal hex values.
  • Light values equal today's colours, so the app looks unchanged. Checked three ways:
    • Pairs: in headless Chromium, 51 pairs (each palette step in use, plus the opacity variants, against its mapped name) render byte-identical sRGB. The one exception is stone-600 → muted-ink, one unit off as noted above.
    • Editor at 1440px: the same Document with 13 Highlights (one current), a quote and inline code. Its computed colours for the Editor, blockquote, code, Highlight, current Highlight, hovered Highlight, main and body are identical under the previous commit's stylesheet and under this one.
    • By eye: the screenshots look the same.
  • No dark values are defined yet.
  • Checks pass: pnpm test (1021), pnpm typecheck, pnpm run gates and pnpm build, run after rebasing on the latest v1.3.

Invariants: CSS only. No new affordance, no Worker route, no third-party fetch, no Dexie change, no DOM test layer, and no change to the findings schema. Highlights still have no box-shadow and no border-radius.

🤖 Generated with Claude Code

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 26, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-26T09:40:23.145890Z baac9cd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Paper, ink, muted ink, rule, mark, current mark, warning, failure and
milestone become Tailwind theme colours whose light values are the
colours the app uses today. The Editor's stylesheet moves onto names,
with five supporting names (the Highlight's underline and hover, the
Current Finding's underline and ring, inline code, links) so it holds no
literal colour. Nothing on screen changes; the palette classes still
work, and no dark values are defined yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
< 8000 div data-view-component="true" class="TimelineItem TimelineItem--condensed">
The three batches that move components onto the names run in parallel,
so the whole vocabulary lands here: surface and ink ladders, rule steps,
a focus ring, warning and failure surfaces and rules, the milestone's
ink, and names for the Judge's agreement and word diff, a Violation, a
passed Connection test and the tool's links. A table maps each palette
class to its name. Light values stay today's colours, and there are
still no dark values.

The Editor's inline code takes `sunk`, which is the same stone-100, and
its links take `prose-link`, because the Editor's blue and the palette's
blue-700 differ today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0