Repository navigation
Colour names with today's colours - #77
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Paper, ink, muted ink, rule, mark, current mark, warning, failure and milestone become Tailwind theme colours whose light values are the colours the app uses today. The Editor's stylesheet moves onto names, with five supporting names (the Highlight's underline and hover, the Current Finding's underline and ring, inline code, links) so it holds no literal colour. Nothing on screen changes; the palette classes still work, and no dark values are defined yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
The three batches that move components onto the names run in parallel, so the whole vocabulary lands here: surface and ink ladders, rule steps, a focus ring, warning and failure surfaces and rules, the milestone's ink, and names for the Judge's agreement and word diff, a Violation, a passed Connection test and the tool's links. A table maps each palette class to its name. Light values stay today's colours, and there are still no dark values. The Editor's inline code takes `sunk`, which is the same stone-100, and its links take `prose-link`, because the Editor's blue and the palette's blue-700 differ today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
kiran-brahma
force-pushed
the
v1.3-58
branch
from
September 26, 2026 09:42
baac9cd to
797ccbc
Compare
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this
30A1
suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #57. Closes #58.
The expand step of the colour refactor. Only
src/index.csschanges:@themeblock now names every colour the app uses by what it means.index.css.Components are unchanged. The palette classes still work, and no dark values are defined.
The names
paper,ink,muted-ink,rule,mark,current-mark,warning,failure,milestone.ground(stone-50, the app behind the page),sunk(stone-100),sunk-strong(stone-200).ink,soft-ink,quiet-ink,muted-ink,faint-ink,ghost-ink(stone-900 down to stone-400). Alsoon-inkfor text on an ink fill.rule-faint,rule-soft,rule,rule-strong,rule-focus(stone-100 to stone-500), andfocusfor the stone-600 focus ring.mark-line,mark-hover,current-mark-line, andmark-wash(amber-100, the Current Finding's row).warning-soft,warning-muted,warning-focus,warning-surface,warning-rule,warning-rule-strong.milestone-ink, the badge's text. The badge can then stop borrowing warning's amber (story 208) without touching warning.failure-surface,failure-rule,failure-focus. Andsuccess(emerald-700, a Connection test that passed).agreement,agreement-surface,agreement-rulefor a Prediction the Judge agreed with.added,added-ink,removedandremoved-inkfor its word diff.violation(the strike),violation-ink,violation-surface,violation-wash,violation-rule,violation-focus.linkandlink-hoverfor the tool's own text, andprose-linkfor the Writer's prose.Opacity modifiers carry over unchanged:
bg-stone-100/60becomesbg-sunk/60.Every palette class has one stable meaning, with three contextual cases the table spells out:
text-amber-900iswarningin general, butmilestone-inkon the milestone badge.text-amber-50on the warning-filled Restore button iswarning-surface.text-stone-100on the raw-responseink/90block issunk, the same pairing the Editor's code block uses.Two places where one name cannot equal both of today's colours:
#1d4ed8(Tailwind v3's blue-700). The palette classtext-blue-700is v4's oklch value, which renders#1447e6, a visibly brighter blue. So they get two names,prose-linkandlink. A later batch can unify them deliberately.muted-ink: it keeps the Editor's#57534e.text-stone-600renders#57534d, one unit off in the blue channel. That is not visible, so I chose one name over two.Acceptance criteria
index.csswith Tailwind's compiler. It generatesbg-,text-andborder-utilities for the nine required names.muted-ink, one unit off as noted above.mainandbodyare identical under the previous commit's stylesheet and under this one.pnpm test(1021),pnpm typecheck,pnpm run gatesandpnpm build, run after rebasing on the latestv1.3.Invariants: CSS only. No new affordance, no Worker route, no third-party fetch, no Dexie change, no DOM test layer, and no change to the findings schema. Highlights still have no box-shadow and no border-radius.
🤖 Generated with Claude Code