Repository navigation
A paragraph that opens with an ordinal is counted as one sentence - #72
Merged
Merged
Conversation
…ence A Paragraph that opens with an ordinal (1984. The year...) escapes to the same canonical shape as an escaped list marker, so the sentence rule reads it as one sentence. The Writer accepted the rule (issue #51, option 1): the metrics gloss now states the limitation, a help content test asserts it, and a sentences test pins the unchanged segmentation. The canonical string does not change, so no stored anchor offsets move. Closes #51. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51.
Implements the Writer's decision (option 1, accept and document): the metrics panel's own gloss now says that a paragraph opening with a number and a period (
1984. …) is counted as one sentence, and why. The canonical string andsentences.tsbehaviour are unchanged, so no stored anchor offsets move.src/help/helpContent.ts:PANEL_GLOSSES.metrics.textstates the limitation.src/help/helpContent.test.ts: asserts the gloss states it. The existing voice, banned-word, em-dash and ordinary-case tests also pass on the new text.src/core/sentences.test.ts: pins the current segmentation of1984\. The year Orwell chose.as one sentence.src/core/sentences.ts: changed the header comment only, to name the accepted limitation. No code changed.Acceptance criteria
PANEL_GLOSSES.metricsand on screen in the Rhythm panel (pnpm dev+ headless Chromium screenshot).helpContent.test.ts, new "panel glosses" case).sentences.tsbehaviour unchanged: verified. No code changed, and a new pinning test plus the existing escape tests pass.canonicalText.tsuntouched).pnpm test(999 passed),pnpm typecheck,pnpm run gates,pnpm buildall pass.Found while checking in the app, outside this ticket: when you type
1984.at the start of a line in the Editor, the ordered-list input rule turns it into a numbered list item. So in the live Editor the case usually shows up as a list rather than as an escaped paragraph.🤖 Generated with Claude Code
Generated by Claude Code