Repository navigation
The service-worker cache name is a constant, but migrations.md claims it is release-keyed - #70
Merged
Merged
Conversation
docs/migrations.md and the public/sw.js comment claimed the cache name is release-keyed and bumped on every deploy, so activate would delete the previous release's cache. CACHE_NAME has always been a constant and nothing bumps it. Correct both to name syncShellAssets, run on every successful online navigation, as what keeps the cache on the current deploy. No behaviour change. Closes #48. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48.
Follows the Writer's decision on the issue (2026-09-26): correct the docs.
docs/migrations.mdand thepublic/sw.jscomment now name the navigation-timesyncShellAssetsprune as the mechanism that keeps the shell cache on the current deploy and makes a rollback work.CACHE_NAMEstays a constant.Acceptance
docs/migrations.mdrollback passage rewritten to name the navigation-timesyncShellAssetsprune as the mechanism doing the work (also the opening "once the service worker is forced to advance" clause, which contradicted it). Verified by reading the diff.public/sw.jscomment aboveCACHE_NAMEcorrected. Verified by reading the diff.CACHE_NAMEstays a constant: no code change, no deploy step, no migration-policy change. Verified: only a comment changed insw.js.pnpm test(997 passed),pnpm typecheck,pnpm run gates,pnpm buildall pass.Not changed:
docs/decisions/obelus-v1-goldilocks.md:300also mentions a "cache name keyed to the release". I left it alone because it is a dated decision record and falls outside what this ticket covers.🤖 Generated with Claude Code
Generated by Claude Code