8000 The service-worker cache name is a constant, but migrations.md claims it is release-keyed by kiran-brahma · Pull Request #70 · kiran-brahma/writing-tool · GitHub
[go: up one dir, main page]

Skip to content

The service-worker cache name is a constant, but migrations.md claims it is release-keyed - #70

Merged
kiran-brahma merged 1 commit into
v1.3from
v1.3-48
Sep 26, 2026
Merged

kiran-brahma merged 1 commit into
v1.3from
v1.3-48

Conversation

@kiran-brahma
Copy link
Copy Markdown
Owner

Closes #48.

Follows the Writer's decision on the issue (2026-09-26): correct the docs. docs/migrations.md and the public/sw.js comment now name the navigation-time syncShellAssets prune as the mechanism that keeps the shell cache on the current deploy and makes a rollback work. CACHE_NAME stays a constant.

Acceptance

  • docs/migrations.md rollback passage rewritten to name the navigation-time syncShellAssets prune as the mechanism doing the work (also the opening "once the service worker is forced to advance" clause, which contradicted it). Verified by reading the diff.
  • "What enforces it" bullet no longer claims a release-keyed cache name. Verified by reading the diff.
  • public/sw.js comment above CACHE_NAME corrected. Verified by reading the diff.
  • CACHE_NAME stays a constant: no code change, no deploy step, no migration-policy change. Verified: only a comment changed in sw.js.
  • pnpm test (997 passed), pnpm typecheck, pnpm run gates, pnpm build all pass.

Not changed: docs/decisions/obelus-v1-goldilocks.md:300 also mentions a "cache name keyed to the release". I left it alone because it is a dated decision record and falls outside what this ticket covers.

🤖 Generated with Claude Code


Generated by Claude Code

docs/migrations.md and the public/sw.js comment claimed the cache name
is release-keyed and bumped on every deploy, so activate would delete
the previous release's cache. CACHE_NAME has always been a constant and
nothing bumps it. Correct both to name syncShellAssets, run on every
successful online navigation, as what keeps the cache on the current
deploy. No behaviour change.

Closes #48.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FjB3Gu8vhg5enkAneTdqga
@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 26, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-26T09:32:42.352752Z bbe9099 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0