You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload
8000
a> to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The passive pass is not reported at note severity, as story 138 requires #53
docs/specs/obelus-v1.1.md story 138 asks for the passive pass to be reported at note severity:
138. As a writer, I want the passive pass reported at note severity with its exception stated, so
that [...]
and line 265 repeats it: "A new rule pass passive, enabled: true, at note severity, with a
configurable auxiliary list."
The exception is implemented; the severity is not representable anywhere in the code:
src/core/finding.ts — Finding has no severity field.
src/core/rulePass.ts:421-427 — the Williams exception is carried in the Finding's diagnosis
text, which is correct, but nothing distinguishes this Finding from any other.
src/editor/FindingRow.tsx — every Finding renders identically, with no severity treatment.
The findings schema sent to a model has no severity field either, so this is a rule-pass
concept and does not touch the constitution.
Impact
The requirement is only partly delivered: the Writer gets the passive Finding with its exception
stated, but it arrives with the same weight as a cliché or a repetition Finding. A "note" that is
indistinguishable from a regular Finding is not a note.
Fix
Add an optional severity?: "note" to the Rule-Pass portion of Finding (rule passes only — it must
not reach the model schema), set it on the passive pass, and give it a distinct treatment in FindingRow and the queue. Keep the model-facing schema closed and unchanged.
Fixed in #86 (merged into v1.3). Finding has an optional severity: "note" set only by the passive rule; reconcile carries it from the new Run. The row and the Callout show a quiet "Note" label with lighter issue weight. Queue order and Band membership unchanged. The model findings schema and parser are untouched, and a test proves a model response with severity yields a Finding without it; harness passes. No Dexie migration (field not indexed, version unchanged).
For /domain-modeling: CONTEXT.md lists "note" under Avoid for a Finding; it is used here only as the spec's severity name (story 138).
Activity
kiran-brahma commentedon Sep 26, 2026
Sequenced after #66 (Rail modes), which reshapes the Finding row, so the note treatment is built once on the new row and in v1.3's colour names.
Report the passive pass at note severity (#53) (#86)
kiran-brahma commentedon Sep 26, 2026
Fixed in #86 (merged into
v1.3).Findinghas an optionalseverity: "note"set only by the passive rule; reconcile carries it from the new Run. The row and the Callout show a quiet "Note" label with lighter issue weight. Queue order and Band membership unchanged. The model findings schema and parser are untouched, and a test proves a model response withseverityyields a Finding without it; harness passes. No Dexie migration (field not indexed, version unchanged).For
/domain-modeling: CONTEXT.md lists "note" under Avoid for a Finding; it is used here only as the spec's severity name (story 138).Generated by Claude Code